From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [PATCH 1/5] ARM: dts: exynos4x12: Add ADC's dt data to read raw data Date: Wed, 12 Mar 2014 12:31:55 +0900 Message-ID: <531FD52B.8040007@samsung.com> References: <1394524494-30641-1-git-send-email-cw00.choi@samsung.com> <1394524494-30641-2-git-send-email-cw00.choi@samsung.com> <531EFF7F.9010405@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout3.samsung.com ([203.254.224.33]:12561 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752789AbaCLDb5 (ORCPT ); Tue, 11 Mar 2014 23:31:57 -0400 In-reply-to: <531EFF7F.9010405@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Tomasz Figa Cc: kgene.kim@samsung.com, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kyungmin.park@samsung.com, rob.herring@calxeda.com, pawel.moll@arm.com, mark.rutland@arm.com, swarren@wwwdotorg.org, ijc+devicetree@hellion.org.uk, linux@arm.linux.org.uk Hi Tomasz, On 03/11/2014 09:20 PM, Tomasz Figa wrote: > Hi Chanwoo, > > On 11.03.2014 08:54, Chanwoo Choi wrote: >> This patch add ADC(Analog to Digital Converter)'s dt data to get raw data >> with IIO subsystem. Usually, ADC is used to check temperature, jack type, and >> so on. >> > > 8< --- > >> Register map >> - <0x126C0000 0x100> : ADC register's base address >> - <0x10020718 0x4> : ADC_PHY_CONTROL, TS-ADC control register address >> >> Clock >> - <&clock 326> : ADC clock (clock name :'tsadc') >> >> Interrupt >> - INTG10[3] : ADC for General ADC > > --- >8 > > I don't think there is a need to include such data in commit message. A commit message should say what is done and why it's done (and sometimes how it's done, in case of some complex code being added) and I guess that's all. OK, I'll remove it on patch description. > >> >> Signed-off-by: Chanwoo Choi >> Signed-off-by: Kyungmin Park >> --- >> arch/arm/boot/dts/exynos4x12.dtsi | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi >> index 5c412aa..5a3e551 100644 >> --- a/arch/arm/boot/dts/exynos4x12.dtsi >> +++ b/arch/arm/boot/dts/exynos4x12.dtsi >> @@ -80,6 +80,18 @@ >> }; >> }; >> >> + adc: adc@126C0000 { >> + compatible = "samsung,exynos-adc-v1"; >> + reg = <0x126C0000 0x100>, <0x10020718 0x4>; >> + interrupt-parent = <&combiner>; >> + interrupts = <10 3>; >> + clocks = <&clock 326>; > > Please use clock macros instead of numbers, as introduced by Andrzej Hajda's patches merged to Kgene's tree. > OK, I'll modify it. Thanks, Chanwoo Choi From mboxrd@z Thu Jan 1 00:00:00 1970 From: cw00.choi@samsung.com (Chanwoo Choi) Date: Wed, 12 Mar 2014 12:31:55 +0900 Subject: [PATCH 1/5] ARM: dts: exynos4x12: Add ADC's dt data to read raw data In-Reply-To: <531EFF7F.9010405@samsung.com> References: <1394524494-30641-1-git-send-email-cw00.choi@samsung.com> <1394524494-30641-2-git-send-email-cw00.choi@samsung.com> <531EFF7F.9010405@samsung.com> Message-ID: <531FD52B.8040007@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Tomasz, On 03/11/2014 09:20 PM, Tomasz Figa wrote: > Hi Chanwoo, > > On 11.03.2014 08:54, Chanwoo Choi wrote: >> This patch add ADC(Analog to Digital Converter)'s dt data to get raw data >> with IIO subsystem. Usually, ADC is used to check temperature, jack type, and >> so on. >> > > 8< --- > >> Register map >> - <0x126C0000 0x100> : ADC register's base address >> - <0x10020718 0x4> : ADC_PHY_CONTROL, TS-ADC control register address >> >> Clock >> - <&clock 326> : ADC clock (clock name :'tsadc') >> >> Interrupt >> - INTG10[3] : ADC for General ADC > > --- >8 > > I don't think there is a need to include such data in commit message. A commit message should say what is done and why it's done (and sometimes how it's done, in case of some complex code being added) and I guess that's all. OK, I'll remove it on patch description. > >> >> Signed-off-by: Chanwoo Choi >> Signed-off-by: Kyungmin Park >> --- >> arch/arm/boot/dts/exynos4x12.dtsi | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi >> index 5c412aa..5a3e551 100644 >> --- a/arch/arm/boot/dts/exynos4x12.dtsi >> +++ b/arch/arm/boot/dts/exynos4x12.dtsi >> @@ -80,6 +80,18 @@ >> }; >> }; >> >> + adc: adc at 126C0000 { >> + compatible = "samsung,exynos-adc-v1"; >> + reg = <0x126C0000 0x100>, <0x10020718 0x4>; >> + interrupt-parent = <&combiner>; >> + interrupts = <10 3>; >> + clocks = <&clock 326>; > > Please use clock macros instead of numbers, as introduced by Andrzej Hajda's patches merged to Kgene's tree. > OK, I'll modify it. Thanks, Chanwoo Choi