From: Alex Elder <elder@ieee.org>
To: Guangliang Zhao <lucienchao@gmail.com>, ceph-devel@vger.kernel.org
Cc: sage@inktank.com
Subject: Re: [PATCH 0/3] patches for rbd
Date: Wed, 12 Mar 2014 00:28:16 -0500 [thread overview]
Message-ID: <531FF070.9000803@ieee.org> (raw)
In-Reply-To: <1394598285-17225-1-git-send-email-lucienchao@gmail.com>
On 03/11/2014 11:24 PM, Guangliang Zhao wrote:
> Hi,
>
> I am sorry that didn't notice Jean-Tiare's mail at all, just sage's
> reminds me.
>
> There are 3 patches, the first is optimization for rbd writing, the
> remaining two are support for rbd discard. If you have completed the
> discard things, just ignore them.
>
> Guangliang Zhao (3):
> rbd: skip the copyup when an entire object writing
> rbd: extend the operation type
> rbd: add discard support for rbd
>
> drivers/block/rbd.c | 190 +++++++++++++++++++++++++++++++++++++++++----------
> 1 file changed, 154 insertions(+), 36 deletions(-)
>
Oh, one more thing. I reviewed only the code changes presented
here. I did not go back to walk through the discard call chains
to make sure you're doing things correctly. I'm just assuming
that, and based on that, I think your changes look overall correct
to me.
-Alex
next prev parent reply other threads:[~2014-03-12 5:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 4:24 [PATCH 0/3] patches for rbd Guangliang Zhao
2014-03-12 4:24 ` [PATCH 1/3] rbd: skip the copyup when an entire object writing Guangliang Zhao
2014-03-12 4:39 ` Alex Elder
2014-03-12 4:24 ` [PATCH 2/3] rbd: extend the operation type Guangliang Zhao
2014-03-12 5:01 ` Alex Elder
2014-03-12 4:24 ` [PATCH 3/3] rbd: add discard support for rbd Guangliang Zhao
2014-03-12 5:26 ` Alex Elder
2014-03-12 5:28 ` Alex Elder [this message]
2014-03-12 8:12 ` [PATCH 0/3] patches " Guangliang Zhao
2014-03-12 9:34 ` Jean-Tiare LE BIGOT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531FF070.9000803@ieee.org \
--to=elder@ieee.org \
--cc=ceph-devel@vger.kernel.org \
--cc=lucienchao@gmail.com \
--cc=sage@inktank.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.