All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: Jonathan Cameron <jic23@kernel.org>, linux-iio@vger.kernel.org
Subject: Re: [PATCH 0/5] iio: Minor cleanups to spear ADC driver followed by staging graduation.
Date: Wed, 12 Mar 2014 07:50:51 +0100	[thread overview]
Message-ID: <532003CB.1000803@denx.de> (raw)
In-Reply-To: <1394570219-7672-1-git-send-email-jic23@kernel.org>

On 11.03.2014 21:36, Jonathan Cameron wrote:
> This driver has been reasonably clean since it was first merged within the
> staging tree.  If it had been submitted after the IIO core was outside of
> staging we might have taken it as is. I did a final review and the first 4
> patches of this series rework various minor aspects of the driver.
>
> Whilst it is a slow driver, the device tree matches at the lowest level seemed
> a little unwise so the largest rework is concerned with centralising that
> logic using a classic ops structure of function pointers.  The other large
> change was to move to using the info_mask_shared_by_all approach to handle
> sampling frequency.  This is something I am slowly propogating across the
> whole tree, but might as well be done whilst we are looking at this driver.
>
> I don't have hardware and whilst I think these are all changes that are
> possible to easily verify by eye, a tested by would be most welcome!
>
> Note this is the first driver I'm suggesting moving out of staging following
> Greg's entirely reasonable question of 'What's wrong with the stuff that is
> left?'  Any help with this sort of final cleanup and move would be most
> welcome.

Jonathan, thanks for working on this. Really appreciated. I don't have a 
spear600 board at hand right now. But all your changes seem reasonable. So:

Ackey-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

      parent reply	other threads:[~2014-03-12  6:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-11 20:36 [PATCH 0/5] iio: Minor cleanups to spear ADC driver followed by staging graduation Jonathan Cameron
2014-03-11 20:36 ` [PATCH 1/5] staging:iio:adc:spear adc - prefix defines to avoid namespace clashes Jonathan Cameron
2014-03-11 20:36 ` [PATCH 2/5] staging:iio:adc:spear adc rework so that device tree queries are all in probe Jonathan Cameron
2014-03-11 20:36 ` [PATCH 3/5] staging:iio:adc:spear_adc drop initialization of unused scan_type Jonathan Cameron
2014-03-11 20:36 ` [PATCH 4/5] staging:iio:adc:spear_adc use info_mask_shared_by_all for samp freq Jonathan Cameron
2014-03-12 20:31   ` Hartmut Knaack
2014-03-15 14:49     ` Jonathan Cameron
2014-03-11 20:36 ` [PATCH 5/5] iio:adc:spear_adc move out of staging Jonathan Cameron
2014-03-12 20:46   ` Hartmut Knaack
2014-03-13 15:45     ` Jonathan Cameron
2014-03-12  6:50 ` Stefan Roese [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=532003CB.1000803@denx.de \
    --to=sr@denx.de \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.