From: Sebastian Huber <sebastian.huber@embedded-brains.de>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] hw/timer/grlib_gptimer: Avoid integer overflows
Date: Wed, 12 Mar 2014 10:48:21 +0100 [thread overview]
Message-ID: <53202D65.2090805@embedded-brains.de> (raw)
In-Reply-To: <531354A9.9020705@embedded-brains.de>
Hello,
On 2014-03-02 16:56, Sebastian Huber wrote:
> On 03/02/2014 02:17 PM, Michael Tokarev wrote:
>> 26.02.2014 11:53, Sebastian Huber wrote:
>>> Ping.
>> There was another comment on this, about the first hunk,
>> see https://lists.gnu.org/archive/html/qemu-trivial/2014-02/msg00067.html
>>
>> Note that the comment below this line mentions the +1 which is
>> being removed.
>
> I think I addressed this issue with the following sentence in the commit
> message of v2:
>
> "Use the GPTIMER counter value for tracing to avoid an overflow of the 32-bit
> value passed to trace_grlib_gptimer_enable()."
>
should I better split the patch into two parts?
--
Sebastian Huber, embedded brains GmbH
Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : sebastian.huber@embedded-brains.de
PGP : Public key available on request.
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Huber <sebastian.huber@embedded-brains.de>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] hw/timer/grlib_gptimer: Avoid integer overflows
Date: Wed, 12 Mar 2014 10:48:21 +0100 [thread overview]
Message-ID: <53202D65.2090805@embedded-brains.de> (raw)
In-Reply-To: <531354A9.9020705@embedded-brains.de>
Hello,
On 2014-03-02 16:56, Sebastian Huber wrote:
> On 03/02/2014 02:17 PM, Michael Tokarev wrote:
>> 26.02.2014 11:53, Sebastian Huber wrote:
>>> Ping.
>> There was another comment on this, about the first hunk,
>> see https://lists.gnu.org/archive/html/qemu-trivial/2014-02/msg00067.html
>>
>> Note that the comment below this line mentions the +1 which is
>> being removed.
>
> I think I addressed this issue with the following sentence in the commit
> message of v2:
>
> "Use the GPTIMER counter value for tracing to avoid an overflow of the 32-bit
> value passed to trace_grlib_gptimer_enable()."
>
should I better split the patch into two parts?
--
Sebastian Huber, embedded brains GmbH
Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : sebastian.huber@embedded-brains.de
PGP : Public key available on request.
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
next prev parent reply other threads:[~2014-03-12 9:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-16 11:12 [Qemu-trivial] [PATCH v2] hw/timer/grlib_gptimer: Avoid integer overflows Sebastian Huber
2014-02-16 11:12 ` [Qemu-devel] " Sebastian Huber
2014-02-26 7:53 ` [Qemu-trivial] " Sebastian Huber
2014-02-26 7:53 ` Sebastian Huber
2014-03-02 13:17 ` [Qemu-trivial] " Michael Tokarev
2014-03-02 13:17 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-03-02 15:56 ` [Qemu-trivial] [Qemu-devel] " Sebastian Huber
2014-03-02 15:56 ` [Qemu-devel] [Qemu-trivial] " Sebastian Huber
2014-03-12 9:48 ` Sebastian Huber [this message]
2014-03-12 9:48 ` Sebastian Huber
2014-03-14 16:13 ` Michael Tokarev
2014-03-14 16:13 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53202D65.2090805@embedded-brains.de \
--to=sebastian.huber@embedded-brains.de \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.