From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] pcsc-lite: not available for static builds
Date: Wed, 12 Mar 2014 10:08:12 +0000 [thread overview]
Message-ID: <5320320C.3050705@imgtec.com> (raw)
In-Reply-To: <871ty8qs2j.fsf@dell.be.48ers.dk>
On 03/11/2014 10:38 PM, Peter Korsgaard wrote:
>>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:
>
> > This package requires dlopen and checks for it in the configure phase.
> > If it's not present, then the build process is stopped.
>
> > Fixes:
> > http://autobuild.buildroot.net/results/34b/34b83c3ea4a8aac6aeda225e5859bd318b13a676/
>
> > Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> > ---
> > package/pcsc-lite/Config.in | 4 ++++
> > 1 files changed, 4 insertions(+), 0 deletions(-)
>
> > diff --git a/package/pcsc-lite/Config.in b/package/pcsc-lite/Config.in
> > index aab42e8..24981bd 100644
> > --- a/package/pcsc-lite/Config.in
> > +++ b/package/pcsc-lite/Config.in
> > @@ -2,6 +2,7 @@ config BR2_PACKAGE_PCSC_LITE
> > bool "pcsc-lite"
> > depends on BR2_TOOLCHAIN_HAS_THREADS
> > depends on BR2_USE_MMU # fork()
> > + depends on !BR2_PREFER_STATIC_LIB
>
> This dependency should also be propagated to the reverse dependencies of pcsc-lite.
Have you done this, or do you want I submit patches for it?
> > help
> > Middleware to access smart card using SCard API (PC/SC).
>
> > @@ -31,3 +32,6 @@ endif
> > comment "pcsc-lite needs a toolchain w/ threads"
> > depends on BR2_USE_MMU
> > depends on !BR2_TOOLCHAIN_HAS_THREADS
> > +
> > +comment "pcsc-lite needs a toolchain w/ dynamic library"
> > + depends on BR2_PREFER_STATIC_LIB
>
> We normally merge all the toolchain dependency options together, E.G.:
>
> comment "pcsc-lite needs a toolchain w/ threads, dynamic library"
> depends on BR2_USE_MMU
> depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_PREFER_STATIC_LIB
>
> Committed with these changes, thanks.
>
--
Vincent
next prev parent reply other threads:[~2014-03-12 10:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 12:10 [Buildroot] [PATCH] pcsc-lite: not available for static builds Vicente Olivert Riera
2014-03-11 22:38 ` Peter Korsgaard
2014-03-12 10:08 ` Vicente Olivert Riera [this message]
2014-03-12 10:14 ` Vicente Olivert Riera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5320320C.3050705@imgtec.com \
--to=vincent.riera@imgtec.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.