From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v4] mk: filter duplicate configuration entries Date: Mon, 11 Jul 2016 14:47:53 +0200 Message-ID: <5320412.bppHEIE6QQ@xps13> References: <1467796386-20291-1-git-send-email-christian.ehrhardt@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: ferruh.yigit@intel.com, dev@dpdk.org To: Christian Ehrhardt Return-path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id DD79E2B91 for ; Mon, 11 Jul 2016 14:47:58 +0200 (CEST) Received: by mail-wm0-f51.google.com with SMTP id f126so88100962wma.1 for ; Mon, 11 Jul 2016 05:47:58 -0700 (PDT) In-Reply-To: <1467796386-20291-1-git-send-email-christian.ehrhardt@canonical.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-07-06 11:13, Christian Ehrhardt: > *updates in v4* > - replace awk usage with sed > - re-add the old loop to be able to get rid of awk > - add more explanation to the header of the makefile section > > *updates in v3* > - replace tac with sed '1!G;h;$!d' to avoid build time dependency > > *updates in v2* > - move to .config target > - fix usage order of tac > - simplify inner section by only using awk (instead of awk+loop+bash+sed) > > Due to the hierarchy and the demand to keep the base config showing all > options, some config keys end up multiple times in the .config file. > > Due to the way the actual config is sourced only the last entry is > important. That can confuse people changing values in .config which > are then ignored. > > A suggested solution was to filter for duplicates at the end of the > actual config step which is implemented here. > > Signed-off-by: Christian Ehrhardt Applied, thanks