Re: [PATCH v4 10/10] rc: img-ir: add Sanyo decoder module

[James Hogan <james.hogan@imgtec.com>]

On 12/03/14 10:57, Mauro Carvalho Chehab wrote:
> Hi James,
> 
> Em Fri, 28 Feb 2014 23:29:00 +0000
> James Hogan <james.hogan@imgtec.com> escreveu:
> 
>> Add an img-ir module for decoding the Sanyo infrared protocol.
> 
> After applying this series, some new warnings are popping up,
> when compiled with W=1:
> 
> drivers/media/rc/img-ir/img-ir-hw.c: In function 'img_ir_free_timing':
> drivers/media/rc/img-ir/img-ir-hw.c:228:23: warning: variable 'maxlen' set but not used [-Wunused-but-set-variable]
>   unsigned int minlen, maxlen, ft_min;
>                        ^
> drivers/media/rc/img-ir/img-ir-hw.c:228:15: warning: variable 'minlen' set but not used [-Wunused-but-set-variable]
>   unsigned int minlen, maxlen, ft_min;
>                ^
> drivers/media/rc/img-ir/img-ir-jvc.c:76:3: warning: initialized field overwritten [-Woverride-init]
>    },
>    ^
> drivers/media/rc/img-ir/img-ir-jvc.c:76:3: warning: (near initialization for 'img_ir_jvc.timings.s00') [-Woverride-init]
> drivers/media/rc/img-ir/img-ir-jvc.c:81:3: warning: initialized field overwritten [-Woverride-init]
>    },
>    ^
> drivers/media/rc/img-ir/img-ir-jvc.c:81:3: warning: (near initialization for 'img_ir_jvc.timings.s01') [-Woverride-init]
> 
> Please fix.

Ooh yes, I hadn't tried W=1. Both appear to indicate genuine bugs. I'll
fix and do a retest later today.

Thanks
James