Re: [dpdk-dev] [PATCH] net/bnxt: fixes in flow counter mgr

[Thomas Monjalon <thomas@monjalon.net>]

03/08/2020 16:12, Somnath Kotur:
> OVS-DPDK seems to set the reset bit for every flow query. Honor
> the bit by resetting the SW counter values after assigning them.
> Also set the 'hit' bit only if the counter value retrieved by HW
> is non-zero.
> While querying flow stats, use max possible entries in the fc table scan
> for valid entries instead of active entries as the active entry can be in
> any slot in the table.
> 
> This is a critical fix for OVS-DPDK flow aging.
> 
> Fixes: 306c2d28e247 ("net/bnxt: support count action in flow query")
> 
> Reviewed-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>
> Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>

Tags must be in chronological order (Reviewed-by after Signed-off-by).

> ---
>  drivers/net/bnxt/tf_ulp/ulp_fc_mgr.c | 25 +++++++++++++++++--------
>  1 file changed, 17 insertions(+), 8 deletions(-)

That's not a small change.

The title does not convey the impact of the change.

Applied anyway because you insisted on the criticality.