From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH] drm/exynos: add phy settings for RB resolutions Date: Wed, 12 Mar 2014 16:26:32 +0100 Message-ID: <53207CA8.1070100@samsung.com> References: <1394461049-27547-1-git-send-email-s.shirish@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mailout4.w1.samsung.com (mailout4.w1.samsung.com [210.118.77.14]) by gabe.freedesktop.org (Postfix) with ESMTP id 9C6E6FA51A for ; Wed, 12 Mar 2014 08:26:50 -0700 (PDT) Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N2B00HP3XKNZ320@mailout4.w1.samsung.com> for dri-devel@lists.freedesktop.org; Wed, 12 Mar 2014 15:26:47 +0000 (GMT) In-reply-to: <1394461049-27547-1-git-send-email-s.shirish@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Shirish S , dri-devel@lists.freedesktop.org, inki.dae@samsung.com Cc: shirish@chromium.org List-Id: dri-devel@lists.freedesktop.org Hi Shirish, On 10.03.2014 15:17, Shirish S wrote: > below is list of pixel clocks and resoluitons > this patch adds: > > 71000000 - 1280x800@60Hz RB > 73250000 - 800x600@120Hz RB > 88750000 - 1440x900@60Hz RB > 115500000 - 1024x768@120Hz RB > 119000000 - 1680x1050@60Hz RB > > without these pixel clocks' support the mentioned > resolutions fail to be detected in exynos5250. This commit message is poorly written. Please start sentences with capital letters and check spelling before sending. Here follows an example of commit message for this patch: 8<--- This patch adds several new pixel clock settings for HDMI PHY v14 (Exynos5250). Without them following display modes cannot be supported: 71000000 Hz - 1280x800@60Hz RB 73250000 Hz - 800x600@120Hz RB 88750000 Hz - 1440x900@60Hz RB 115500000 Hz - 1024x768@120Hz RB 119000000 Hz - 1680x1050@60Hz RB --->8 > > Signed-off-by: Shirish S > --- > drivers/gpu/drm/exynos/exynos_hdmi.c | 45 ++++++++++++++++++++++++++++++++++ > 1 file changed, 45 insertions(+) > > diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c > index c021ddc..650ce48 100644 > --- a/drivers/gpu/drm/exynos/exynos_hdmi.c > +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c > @@ -303,6 +303,24 @@ static const struct hdmiphy_config hdmiphy_v14_configs[] = { > }, > }, > { > + .pixel_clock = 71000000, > + .conf = { > + 0x01, 0x91, 0x1E, 0x15, 0x40, 0x3C, 0xCE, 0x08, Lowercase is preferred by kernel coding style for hexadecimal values. Best regards, Tomasz