From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55734)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WNmLC-00058F-FT
	for qemu-devel@nongnu.org; Wed, 12 Mar 2014 12:49:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WNmL5-0001kx-6Q
	for qemu-devel@nongnu.org; Wed, 12 Mar 2014 12:49:14 -0400
Received: from cantor2.suse.de ([195.135.220.15]:41252 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WNmL5-0001ib-0d
	for qemu-devel@nongnu.org; Wed, 12 Mar 2014 12:49:07 -0400
Message-ID: <53209001.3080703@suse.de>
Date: Wed, 12 Mar 2014 17:49:05 +0100
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1392821892-26682-1-git-send-email-ehabkost@redhat.com>
	<1392821892-26682-4-git-send-email-ehabkost@redhat.com>
	<532070D2.7050705@suse.de>
	<20140312154228.GG29225@otherpad.lan.raisama.net>
In-Reply-To: <20140312154228.GG29225@otherpad.lan.raisama.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 3/3] target-i386: Enable x2apic by default
 on KVM
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org, Bandan Das <bsd@redhat.com>, Anthony Liguori <aliguori@amazon.com>, Paolo Bonzini <pbonzini@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Richard Henderson <rth@twiddle.net>

Am 12.03.2014 16:42, schrieb Eduardo Habkost:
> On Wed, Mar 12, 2014 at 03:36:02PM +0100, Andreas F=E4rber wrote:
> [...]
>> [snip]
>>
>> Needed rebase:
>>
>> diff --cc hw/i386/pc_piix.c
>> index 5011c3a,ebd442e..0000000
>> --- a/hw/i386/pc_piix.c
>> +++ b/hw/i386/pc_piix.c
>> @@@ -266,7 -266,7 +266,8 @@@ static void pc_compat_1_7(QEMUMachineIn
>>   {
>>       smbios_type1_defaults =3D false;
>>       gigabyte_align =3D false;
>>  +    option_rom_has_mr =3D true;
>> +     x86_cpu_compat_disable_kvm_features(FEAT_1_ECX, CPUID_EXT_X2APIC=
);
>>   }
>>
>>   static void pc_compat_1_6(QEMUMachineInitArgs *args)
>> diff --cc hw/i386/pc_q35.c
>> index 4b0456a,71b05f1..0000000
>> --- a/hw/i386/pc_q35.c
>> +++ b/hw/i386/pc_q35.c
>> @@@ -244,7 -244,8 +244,8 @@@ static void pc_compat_1_7(QEMUMachineIn
>>   {
>>       smbios_type1_defaults =3D false;
>>       gigabyte_align =3D false;
>>  +    option_rom_has_mr =3D true;
>> +     x86_cpu_compat_disable_kvm_features(FEAT_1_ECX, CPUID_EXT_X2APIC=
);
>>  -
>>   }
>>
>>   static void pc_compat_1_6(QEMUMachineInitArgs *args)
>=20
> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
>=20
> (I am guessing there's no need to resubmit. That's right?)

Right, just FYI that there's changes happening on my branch and that
things are still being prepared and retested for submission.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg