From: Sagi Grimberg <sagig@dev.mellanox.co.il>
To: Jens Axboe <axboe@kernel.dk>
Cc: Bart Van Assche <bvanassche@acm.org>,
Or Gerlitz <ogerlitz@mellanox.com>, Oren Duer <oren@mellanox.com>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: blk_iopoll_enabled
Date: Wed, 12 Mar 2014 19:35:07 +0200 [thread overview]
Message-ID: <53209ACB.2080708@dev.mellanox.co.il> (raw)
Hey Jens,
So I'm looking at blk_iopoll for iSER & SRP and I have one gap I would
like to get your input on.
In blk-iopoll.c I see:
int blk_iopoll_enabled = 1;
EXPORT_SYMBOL(blk_iopoll_enabled);
This is set to 1 and exported for everyone to condition and *modify* it.
The documentation says the user must check this when using blk_iopoll.
My question is why? it should always be true shouldn't it?
Moreover, isn't it better to protect it using a get() function of it?
can't someone set it to 0 and shutdown the lights on everyone else?
Thanks,
Sagi.
next reply other threads:[~2014-03-12 17:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 17:35 Sagi Grimberg [this message]
2014-03-13 3:40 ` blk_iopoll_enabled Jens Axboe
2014-03-13 15:34 ` blk_iopoll_enabled Jens Axboe
2014-03-13 18:48 ` blk_iopoll_enabled Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53209ACB.2080708@dev.mellanox.co.il \
--to=sagig@dev.mellanox.co.il \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=oren@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.