From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47770) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNnU5-0006tR-TW for qemu-devel@nongnu.org; Wed, 12 Mar 2014 14:02:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNnU0-00041v-Id for qemu-devel@nongnu.org; Wed, 12 Mar 2014 14:02:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48707) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNnU0-00041i-9d for qemu-devel@nongnu.org; Wed, 12 Mar 2014 14:02:24 -0400 Message-ID: <5320A0FE.4050909@redhat.com> Date: Wed, 12 Mar 2014 19:01:34 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1393425020-24829-1-git-send-email-stefanha@redhat.com> <20140312091726.GB18850@stefanha-thinkpad.muc.redhat.com> In-Reply-To: <20140312091726.GB18850@stefanha-thinkpad.muc.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/3] nbd: fix issues when connection breaks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , Stefan Hajnoczi Cc: Kevin Wolf , nick@bytemark.co.uk, qemu-devel@nongnu.org, bluewindow@h3c.com Il 12/03/2014 10:17, Stefan Hajnoczi ha scritto: > On Wed, Feb 26, 2014 at 03:30:17PM +0100, Stefan Hajnoczi wrote: >> v2: >> * Use qemu-iotests 083 test number to avoid conflicts [kwolf] >> * Test class negotiation without export name [lupine] >> * Test short replies from the server [lupine] >> >> The first patch ensures the nbd_receive_reply() fd handler is unregistered when >> the connection to the server breaks. This avoids high CPU consumption and >> flooding error messages. >> >> The second patch introduces an NBD server fault injection script. Using this >> fake NBD server it is possible to exercise error handling code paths in the NBD >> client. >> >> The third patch adds qemu-iotests test case 083 to verify qemu-io exits with an >> error at each point where the connection can break. >> >> Stefan Hajnoczi (3): >> nbd: close socket if connection breaks >> tests: add nbd-fault-injector.py utility >> qemu-iotests: add 083 NBD client disconnect tests >> >> block/nbd-client.c | 33 ++-- >> tests/qemu-iotests/083 | 129 +++++++++++++++ >> tests/qemu-iotests/083.out | 163 +++++++++++++++++++ >> tests/qemu-iotests/group | 1 + >> tests/qemu-iotests/nbd-fault-injector.py | 264 +++++++++++++++++++++++++++++++ >> 5 files changed, 575 insertions(+), 15 deletions(-) >> create mode 100755 tests/qemu-iotests/083 >> create mode 100644 tests/qemu-iotests/083.out >> create mode 100755 tests/qemu-iotests/nbd-fault-injector.py > > Ping? I'd like to get this fix into 2.0. > Forgot about it, sorry. You can include it in your block tree, otherwise I think it's suitable for hard freeze. Paolo