From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [net-next 12/13] ixgbe: fix some multiline hw_dbg prints Date: Wed, 12 Mar 2014 23:24:03 +0300 Message-ID: <5320C263.9000105@cogentembedded.com> References: <1394603618-1044-1-git-send-email-jeffrey.t.kirsher@intel.com> <1394603618-1044-13-git-send-email-jeffrey.t.kirsher@intel.com> <53207459.5010306@cogentembedded.com> <1394649063.3030.3.camel@jekeller-desk1.amr.corp.intel.com> <5320BF63.30403@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "Kirsher, Jeffrey T" , "davem@davemloft.net" , "netdev@vger.kernel.org" , "gospo@redhat.com" , "sassmann@redhat.com" To: "Keller, Jacob E" Return-path: Received: from mail-lb0-f169.google.com ([209.85.217.169]:34458 "EHLO mail-lb0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750981AbaCLTYI (ORCPT ); Wed, 12 Mar 2014 15:24:08 -0400 Received: by mail-lb0-f169.google.com with SMTP id q8so687665lbi.14 for ; Wed, 12 Mar 2014 12:24:07 -0700 (PDT) In-Reply-To: <5320BF63.30403@cogentembedded.com> Sender: netdev-owner@vger.kernel.org List-ID: On 03/12/2014 11:11 PM, Sergei Shtylyov wrote: >>>> From: Jacob Keller >>>> This patch fixes some formatting on multilined print messages, so that >>>> the text of the print appears on a single line, which aids in grepping >>>> the sourcecode for where the error came from. >>>> Signed-off-by: Jacob Keller >>>> Tested-by: Phil Schmitt >>>> Signed-off-by: Jeff Kirsher >>>> --- >>>> drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c | 8 +++----- >>>> 1 file changed, 3 insertions(+), 5 deletions(-) >>>> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c >>>> b/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c >>>> index 446df3c..3bc9b67 100644 >>>> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c >>>> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c >>>> @@ -512,7 +512,7 @@ out: >>>> * >>>> * Disables link, should be called during D3 power down sequence. >>>> * >>>> - */ >>>> + **/ >>> Hm? What's this for? >> The extra **/ is part of the standard doc format for function headers, > It is not. Reread Documentation/kernel-doc-nano-HOWTO.txt please. Sorry, I messed it myself -- it seems to be an optional part of the format which I've never seen actually used. Anyway, you shouldn't do "drove-by" changes like that, moreover undocumented in the change log. WBR, Sergei