From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34441)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1WNqYM-0003He-TZ
	for qemu-devel@nongnu.org; Wed, 12 Mar 2014 17:19:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1WNqYG-0002yl-VH
	for qemu-devel@nongnu.org; Wed, 12 Mar 2014 17:19:06 -0400
Received: from mx1.redhat.com ([209.132.183.28]:27515)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1WNqYG-0002yg-Ng
	for qemu-devel@nongnu.org; Wed, 12 Mar 2014 17:19:00 -0400
Message-ID: <5320CF40.2040606@redhat.com>
Date: Wed, 12 Mar 2014 22:18:56 +0100
From: Laszlo Ersek <lersek@redhat.com>
MIME-Version: 1.0
References: <1394648890-933-1-git-send-email-ehabkost@redhat.com>
	<1394648890-933-2-git-send-email-ehabkost@redhat.com>
	<5320CF03.6050309@redhat.com>
In-Reply-To: <5320CF03.6050309@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 1/4] acpi: Add ACPI_CPU_HOTPLUG_ID_LIMIT
	macro
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Cc: Igor Mammedov <imammedo@redhat.com>, =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>, "Michael S. Tsirkin" <mst@redhat.com>

On 03/12/14 22:17, Laszlo Ersek wrote:
> On 03/12/14 19:28, Eduardo Habkost wrote:
>> The new macro will be helpful to allow us to detect too large SMP limits
>> before it is too late.
>>
>> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
>> ---
>>  include/hw/acpi/cpu_hotplug_defs.h | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/include/hw/acpi/cpu_hotplug_defs.h b/include/hw/acpi/cpu_hotplug_defs.h
>> index 2725b50..9f33663 100644
>> --- a/include/hw/acpi/cpu_hotplug_defs.h
>> +++ b/include/hw/acpi/cpu_hotplug_defs.h
>> @@ -17,7 +17,15 @@
>>   * between C and ASL code.
>>   */
>>  #define ACPI_CPU_HOTPLUG_STATUS 4
>> +
>> +/* Limit for CPU arch IDs for CPU hotplug. All hotpluggable CPUs should
>> + * have CPUClass.get_arch_id() < ACPI_CPU_HOTPLUG_ID_LIMIT.
>> + */
>> +#define ACPI_CPU_HOTPLUG_ID_LIMIT 256
>> +
>> +/* 256 CPU IDs, 8 bits per entry: */
>>  #define ACPI_GPE_PROC_LEN 32
>> +
>>  #define ICH9_CPU_HOTPLUG_IO_BASE 0x0CD8
>>  #define PIIX4_CPU_HOTPLUG_IO_BASE 0xaf00
>>  
>>
> 
> You could actually derive ACPI_GPE_PROC_LEN from
> ACPI_CPU_HOTPLUG_ID_LIMIT, by dividing with CHAR_BIT.


(Or vice versa -- get the limit from PROC_LEN by multiplication.)
L.