From: Richard Henderson <rth@twiddle.net>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@amazon.com>
Subject: Re: [Qemu-devel] [PATCH] input: sdl: fix guest_cursor logic.
Date: Wed, 12 Mar 2014 15:13:02 -0700 [thread overview]
Message-ID: <5320DBEE.9000208@twiddle.net> (raw)
In-Reply-To: <1394439837-10021-1-git-send-email-kraxel@redhat.com>
On 03/10/2014 01:23 AM, Gerd Hoffmann wrote:
> + if (guest_cursor) {
> + x -= guest_x;
> + y -= guest_y;
> + guest_x += x;
> + guest_y += y;
> + dx = x;
> + dy = y;
> + }
Why write it in this funny way? Surely better as
dx = x - guest_x;
dy = y - guest_y;
guest_x = x;
guest_y = y;
r~
prev parent reply other threads:[~2014-03-12 22:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 8:23 [Qemu-devel] [PATCH] input: sdl: fix guest_cursor logic Gerd Hoffmann
2014-03-12 22:13 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5320DBEE.9000208@twiddle.net \
--to=rth@twiddle.net \
--cc=aliguori@amazon.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.