From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35606) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNsjG-0008P0-IB for qemu-devel@nongnu.org; Wed, 12 Mar 2014 19:38:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNsjB-0006do-6z for qemu-devel@nongnu.org; Wed, 12 Mar 2014 19:38:30 -0400 Message-ID: <5320EFEE.2030200@suse.de> Date: Thu, 13 Mar 2014 00:38:22 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1392904246-15575-1-git-send-email-aik@ozlabs.ru> <1392904246-15575-3-git-send-email-aik@ozlabs.ru> <5320A24A.3010105@suse.de> <5320E78C.1020101@ozlabs.ru> In-Reply-To: <5320E78C.1020101@ozlabs.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v5 2/6] qdev: introduce FWPathProvider interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy , qemu-devel@nongnu.org Cc: Paolo Bonzini , qemu-ppc@nongnu.org, Alexander Graf Am 13.03.2014 00:02, schrieb Alexey Kardashevskiy: > On 03/13/2014 05:07 AM, Andreas F=C3=A4rber wrote: >> Am 20.02.2014 14:50, schrieb Alexey Kardashevskiy: >>> QEMU supports firmware names for all devices in the QEMU tree but >>> some architectures expect some parts of firmware path names in differ= ent >>> format. >>> >>> This introduces a firmware-pathname-change interface definition. >>> If some machines needs to redefine the firmware path format, it has >>> to add the TYPE_FW_PATH_PROVIDER interface to an object that is above >>> the device on the QOM tree (typically /machine). >>> >>> Signed-off-by: Alexey Kardashevskiy >>> Signed-off-by: Paolo Bonzini >> >> I do not see a reply to my question on v4 and didn't catch bonzini on >> IRC - guessing the two lines should be swapped since both v4 and v5 we= re >> submitted by Alexey? >=20 >=20 > I am actually waiting till machine QOM'fication to finish, then I'll re= post > this patchset. Something changed? Yes, machine QOM'ification is queued on qom-next and the pull request containing it is facing some issues still. But you can already rebase onto git://github.com/afaerber/qemu-cpu.git qom-next branch. In short, the pseries machine needs to use type_init(), call type_register_static(), and the TypeInfo needs to specify as .class_data the QEMUMachine and a .class_init function that assigns that QEMUMachine pointer to mc->qemu_machine as done in machine.c. Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg