From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36931) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNspx-0004Vj-8c for qemu-devel@nongnu.org; Wed, 12 Mar 2014 19:45:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNspn-0000lj-Os for qemu-devel@nongnu.org; Wed, 12 Mar 2014 19:45:25 -0400 Message-ID: <5320F189.3020108@suse.de> Date: Thu, 13 Mar 2014 00:45:13 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1392253715-5416-1-git-send-email-aik@ozlabs.ru> <53157AC7.7070303@ozlabs.ru> <5320726E.3090308@suse.de> <5320E710.4060009@ozlabs.ru> In-Reply-To: <5320E710.4060009@ozlabs.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] xics-kvm: fix reset function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, Paul Mackerras , Alexander Graf Am 13.03.2014 00:00, schrieb Alexey Kardashevskiy: > On 03/13/2014 01:42 AM, Andreas F=C3=A4rber wrote: >> Am 04.03.2014 08:03, schrieb Alexey Kardashevskiy: >>> On 02/13/2014 12:08 PM, Alexey Kardashevskiy wrote: >>>> Currently interrupt priorities are set to 0 (highest) at the very >>>> beginning of the guest execution which is not correct and makes the = guest >>>> produce random interrupt error messages such as: >>>> "Interrupt 0x1001 (real) is invalid, disabling it". >>>> This also prevents interrupt states from correct migration. >>>> >>>> This initializes priority to 0xFF as the emulated XICS does. >>> >>> >>> Ping? Pretty simple patch suggested by Paul Mackerras. >> >> Is this one still needed? Can we document a Suggested-by? >=20 > Yes. >=20 > Suggested-by: Paul Mackerras Thanks, queuing with optimization on my ppc-next: https://github.com/afaerber/qemu-cpu/commits/ppc-next diff --git a/hw/intc/xics_kvm.c b/hw/intc/xics_kvm.c index 04e4e61..c93dae0 100644 --- a/hw/intc/xics_kvm.c +++ b/hw/intc/xics_kvm.c @@ -278,7 +278,7 @@ static void ics_kvm_reset(DeviceState *dev) ics->irqs[i].saved_priority =3D 0xff; } - ics_set_kvm_state(ICS(dev), 1); + ics_set_kvm_state(ics, 1); } static void ics_kvm_realize(DeviceState *dev, Error **errp) Testing TBD. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg