From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38799) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNt3H-0003gz-97 for qemu-devel@nongnu.org; Wed, 12 Mar 2014 19:59:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNt3A-0005TA-0M for qemu-devel@nongnu.org; Wed, 12 Mar 2014 19:59:11 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47400 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNt39-0005T4-Pd for qemu-devel@nongnu.org; Wed, 12 Mar 2014 19:59:03 -0400 Message-ID: <5320F4C5.2040307@suse.de> Date: Thu, 13 Mar 2014 00:59:01 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1394410549-13751-1-git-send-email-afaerber@suse.de> <1394410549-13751-20-git-send-email-afaerber@suse.de> <20140312230853.GB13298@zubnet.me.uk> In-Reply-To: <20140312230853.GB13298@zubnet.me.uk> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom-cpu v2 19/40] cpu: Move breakpoints field from CPU_COMMON to CPUState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stuart Brady , qemu-devel@nongnu.org Am 13.03.2014 00:08, schrieb Stuart Brady: > On Mon, Mar 10, 2014 at 01:15:28AM +0100, Andreas F=E4rber wrote: >> Most targets were using offsetof(CPUFooState, breakpoints) to determin= e >> how much of CPUFooState to clear on reset. Use the next field after >> CPU_COMMON instead, if any, or sizeof(CPUFooState) otherwise. >=20 > Would it not be easier and more readable to add a field replacing > 'breakpoints' just for this purpose, at least for the time being? >=20 > I'm guessing CPU_COMMON_TLB will be getting cleaned up too at some poin= t > so is it really worth avoiding the tiny amount of bloat this imposes? Given the bad timing and having already done the work for v1, I am reluctant to change the somewhat tested code unless there is a bug? Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg