From mboxrd@z Thu Jan 1 00:00:00 1970 From: Emil Velikov Subject: Re: [PATCH 1/3] nouveau: cleanup error handling during nouveau_device_wrap Date: Thu, 13 Mar 2014 01:24:40 +0000 Message-ID: <532108D8.1030401@gmail.com> References: <1394657145-2638-1-git-send-email-emil.l.velikov@gmail.com> <53210428.3030209@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by gabe.freedesktop.org (Postfix) with ESMTP id 7029EFAD77 for ; Wed, 12 Mar 2014 18:22:56 -0700 (PDT) Received: by mail-wi0-f171.google.com with SMTP id hn9so3212605wib.10 for ; Wed, 12 Mar 2014 18:22:56 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Ilia Mirkin Cc: emil.l.velikov@gmail.com, "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org On 13/03/14 01:05, Ilia Mirkin wrote: [snip] > > Not really. drm->drm_version will be 0 if ver fails. > Indeed, dev is calloc'ated by its callers, and if they mess around with that's their own fault. Sorry for the noise. -Emil