From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33580)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WNuiL-0004pc-FL
	for qemu-devel@nongnu.org; Wed, 12 Mar 2014 21:45:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WNuiG-0007Zs-42
	for qemu-devel@nongnu.org; Wed, 12 Mar 2014 21:45:41 -0400
Message-ID: <53210DBC.6040908@suse.de>
Date: Thu, 13 Mar 2014 02:45:32 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1385006938-32515-1-git-send-email-aik@ozlabs.ru>
	<1385006938-32515-2-git-send-email-aik@ozlabs.ru>
In-Reply-To: <1385006938-32515-2-git-send-email-aik@ozlabs.ru>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 1/4] spapr-pci: convert init() callback to
 realize()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, qemu-devel@nongnu.org
Cc: Mike Day <ncmike@ncultra.org>, qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>

Am 21.11.2013 05:08, schrieb Alexey Kardashevskiy:
> This converts the old-style init() callback to a new style realize()
> callback as init() now is supposed to do only trivial initialization.
>=20
> As a part of convertion, this replaces fprintf(stderr) with error_setg(=
)
> as realize() does not "return" any value, instead it puts the extended
> error into **errp.
>=20
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
> Changes:
> v5:
> * finish_finalize() moved to a separate patch
> ---
>  hw/ppc/spapr_pci.c | 44 ++++++++++++++++++++++----------------------
>  1 file changed, 22 insertions(+), 22 deletions(-)
>=20
> diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
> index 7763149..aeb012d 100644
> --- a/hw/ppc/spapr_pci.c
> +++ b/hw/ppc/spapr_pci.c
> @@ -32,6 +32,7 @@
>  #include "exec/address-spaces.h"
>  #include <libfdt.h>
>  #include "trace.h"
> +#include "qemu/error-report.h"
> =20
>  #include "hw/pci/pci_bus.h"
> =20
[snip]

Thanks, applied to ppc-next without the above hunk:
https://github.com/afaerber/qemu-cpu/commits/ppc-next

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg