Re: [PATCH] create_inode: fix gcc -Wall complaints

[Robert Yang <liezhi.yang@windriver.com>]

On 03/13/2014 04:51 AM, Theodore Ts'o wrote:
> On Wed, Mar 12, 2014 at 01:02:19PM -0700, Darrick J. Wong wrote:
>>>
>>> gcc -Wall, via "make gcc-wall" and "make gcc-wall-new"
>>
>> Annoyingly, I ran make gcc-wall on Ubuntu 12.04 (gcc 4.6, glibc 2.15) and got
>> this splat:
>>
>> /usr/include/x86_64-linux-gnu/sys/stat.h:456: multiple definition of `stat'
>> ../lib/libquota.a(quotaio_v2.o):/usr/include/x86_64-linux-gnu/sys/stat.h:456: first defined here
>>
>> Not sure how to fix this, other than changing WFLAGS to start with -std=gnu99.
>> gcc 4.8/glibc 2.19 on Ubuntu 14 are no better.
>
> Hmm, I'm using Debian testing, with gcc 4.8 and eglibc 2.18, and it's
> working fine.  I'm curious, are people noticing problems with gcc-wall
> on Fedora?
>

I got the similar error as Darrick on Fedora 19 x86_64:

$ make gcc-wall

[snip]
rehash.c:504:10: warning: nested extern declaration of ‘ext2fs_dirent_file_type’ 
[-Wnested-externs]
/usr/include/sys/stat.h:455: multiple definition of `stat'
../lib/libquota.a(quotaio_v2.o):/usr/include/sys/stat.h:455: first defined here
/usr/include/sys/stat.h:462: multiple definition of `lstat'
../lib/libquota.a(quotaio_v2.o):/usr/include/sys/stat.h:462: first defined here
/usr/include/sys/stat.h:469: multiple definition of `fstat'
../lib/libquota.a(quotaio_v2.o):/usr/include/sys/stat.h:469: first defined here
/usr/include/sys/stat.h:477: multiple definition of `fstatat'
../lib/libquota.a(quotaio_v2.o):/usr/include/sys/stat.h:477: first defined here
/usr/include/sys/stat.h:485: multiple definition of `mknod'
../lib/libquota.a(quotaio_v2.o):/usr/include/sys/stat.h:485: first defined here
/usr/include/sys/stat.h:494: multiple definition of `mknodat'
../lib/libquota.a(quotaio_v2.o):/usr/include/sys/stat.h:494: first defined here
/usr/include/sys/stat.h:504: multiple definition of `stat64'
../lib/libquota.a(quotaio_v2.o):/usr/include/sys/stat.h:504: first defined here
/usr/include/sys/stat.h:511: multiple definition of `lstat64'
../lib/libquota.a(quotaio_v2.o):/usr/include/sys/stat.h:511: first defined here
/usr/include/sys/stat.h:518: multiple definition of `fstat64'
../lib/libquota.a(quotaio_v2.o):/usr/include/sys/stat.h:518: first defined here
/usr/include/sys/stat.h:526: multiple definition of `fstatat64'
../lib/libquota.a(quotaio_v2.o):/usr/include/sys/stat.h:526: first defined here
collect2: error: ld returned 1 exit status
[snip]

// Robert

> 					- Ted
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html