From: Alex Elder <elder@ieee.org>
To: Guangliang Zhao <lucienchao@gmail.com>, ceph-devel@vger.kernel.org
Subject: Re: [PATCH 3/3 v2] rbd: add discard support for rbd
Date: Wed, 12 Mar 2014 23:49:10 -0500 [thread overview]
Message-ID: <532138C6.6060406@ieee.org> (raw)
In-Reply-To: <1394680896-8554-3-git-send-email-lucienchao@gmail.com>
On 03/12/2014 10:21 PM, Guangliang Zhao wrote:
> This patch add the discard support for rbd driver.
>
> There are there types operation in the driver:
> 1. The objects would be removed if they completely contained
> within the discard range.
> 2. The objects would be truncated if they partly contained within
> the discard range, and align with their boundary.
> 3. Others would be zeroed.
>
> A discard request from blkdev_issue_discard() is defined which
> REQ_WRITE and REQ_DISCARD both marked and no data, so we must
> check the REQ_DISCARD first when getting the request type.
>
> This resolve:
> http://tracker.ceph.com/issues/190
>
> Signed-off-by: Guangliang Zhao <lucienchao@gmail.com>
Looks good.
Reviewed-by: Alex Elder <elder@linaro.org>
next prev parent reply other threads:[~2014-03-13 4:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 3:21 [PATCH 1/3 v2] rbd: skip the copyup when an entire object writing Guangliang Zhao
2014-03-13 3:21 ` [PATCH 2/3 v2] rbd: extend the operation type Guangliang Zhao
2014-03-13 4:47 ` Alex Elder
2014-03-13 5:32 ` Guangliang Zhao
2014-03-27 22:05 ` Josh Durgin
2014-03-13 3:21 ` [PATCH 3/3 v2] rbd: add discard support for rbd Guangliang Zhao
2014-03-13 4:49 ` Alex Elder [this message]
2014-03-27 23:26 ` Josh Durgin
2014-03-13 4:45 ` [PATCH 1/3 v2] rbd: skip the copyup when an entire object writing Alex Elder
2014-03-27 21:48 ` Josh Durgin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532138C6.6060406@ieee.org \
--to=elder@ieee.org \
--cc=ceph-devel@vger.kernel.org \
--cc=lucienchao@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.