diff for duplicates of <53213BC5.8040907@gmail.com> diff --git a/a/1.txt b/N1/1.txt index 5786500..17a5546 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -160,21 +160,24 @@ Thank you for your comments >> + ret = regmap_write(pchip->regmap, >> + REG_CL1_BRT_H, >> + (bl->props.brightness >> 8) & 0x1f); ->> + ret |>> + regmap_write(pchip->regmap, REG_CL1_BRT_L, +>> + ret |= +>> + regmap_write(pchip->regmap, REG_CL1_BRT_L, >> + bl->props.brightness & 0xff); >> + break; >> + case LP8860_LED2: >> + ret = regmap_write(pchip->regmap, >> + REG_CL2_BRT_H, >> + (bl->props.brightness >> 8) & 0x1f); ->> + ret |>> + regmap_write(pchip->regmap, REG_CL2_BRT_L, +>> + ret |= +>> + regmap_write(pchip->regmap, REG_CL2_BRT_L, >> + bl->props.brightness & 0xff); >> + break; >> + case LP8860_LED3: >> + ret = regmap_write(pchip->regmap, >> + REG_CL3_BRT_H, >> + (bl->props.brightness >> 8) & 0x1f); ->> + ret |>> + regmap_write(pchip->regmap, REG_CL3_BRT_L, +>> + ret |= +>> + regmap_write(pchip->regmap, REG_CL3_BRT_L, >> + bl->props.brightness & 0xff); >> + break; >> + default: @@ -403,7 +406,7 @@ Thank you for your comments >> + >> + /* register no. */ >> + tok = strsep((char **)&buf, " ,\n"); ->> + if (tok = NULL) +>> + if (tok == NULL) >> + goto err_input; >> + ret = kstrtouint(tok, 16, ®); >> + if (ret) @@ -411,7 +414,7 @@ Thank you for your comments >> + >> + /* register value */ >> + tok = strsep((char **)&buf, " ,\n"); ->> + if (tok = NULL) +>> + if (tok == NULL) >> + goto err_input; >> + ret = kstrtouint(tok, 16, &data); >> + if (ret) @@ -502,7 +505,8 @@ These sequences are based on the datasheet. >> + props.type = BACKLIGHT_RAW; >> + for (icnt = LP8860_LED0; icnt < LP8860_LED_MAX; icnt++) { >> + props.max_brightness = pdata->max_brt[icnt]; ->> + pchip->bled[icnt] >> + backlight_device_register(lp8860_bled_name[icnt], +>> + pchip->bled[icnt] = +>> + backlight_device_register(lp8860_bled_name[icnt], > devm_* functions will make the code simpler. > Thus, please use devm_backlight_device_register(), instead of > backlight_device_register(). @@ -567,11 +571,11 @@ These sequences are based on the datasheet. >> + return ret; >> + } >> + ->> + if (pdata = NULL) { +>> + if (pdata == NULL) { >> + pdata = devm_kzalloc(pchip->dev, >> + sizeof(struct lp8860_platform_data), >> + GFP_KERNEL); ->> + if (pdata = NULL) +>> + if (pdata == NULL) >> + return -ENOMEM; >> + pdata->max_brt[LP8860_LED0] = 65535; >> + for (icnt = LP8860_LED1; icnt < LP8860_LED_MAX; icnt++) diff --git a/a/content_digest b/N1/content_digest index a45fe6f..cdd990a 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\0001b01cf3c40$a4b347e0$ee19d7a0$%han@samsung.com\0" "From\0Daniel Jeong <gshark.jeong@gmail.com>\0" "Subject\0Re: [PATCH] backlight: add new LP8860 backlight driver\0" - "Date\0Thu, 13 Mar 2014 05:01:57 +0000\0" + "Date\0Thu, 13 Mar 2014 14:01:57 +0900\0" "To\0Jingoo Han <jg1.han@samsung.com>\0" "Cc\0linux-fbdev@vger.kernel.org" linux-kernel@vger.kernel.org @@ -174,21 +174,24 @@ ">> +\t\tret = regmap_write(pchip->regmap,\n" ">> +\t\t\t\t REG_CL1_BRT_H,\n" ">> +\t\t\t\t (bl->props.brightness >> 8) & 0x1f);\n" - ">> +\t\tret |>> +\t\t regmap_write(pchip->regmap, REG_CL1_BRT_L,\n" + ">> +\t\tret |=\n" + ">> +\t\t regmap_write(pchip->regmap, REG_CL1_BRT_L,\n" ">> +\t\t\t\t bl->props.brightness & 0xff);\n" ">> +\t\tbreak;\n" ">> +\tcase LP8860_LED2:\n" ">> +\t\tret = regmap_write(pchip->regmap,\n" ">> +\t\t\t\t REG_CL2_BRT_H,\n" ">> +\t\t\t\t (bl->props.brightness >> 8) & 0x1f);\n" - ">> +\t\tret |>> +\t\t regmap_write(pchip->regmap, REG_CL2_BRT_L,\n" + ">> +\t\tret |=\n" + ">> +\t\t regmap_write(pchip->regmap, REG_CL2_BRT_L,\n" ">> +\t\t\t\t bl->props.brightness & 0xff);\n" ">> +\t\tbreak;\n" ">> +\tcase LP8860_LED3:\n" ">> +\t\tret = regmap_write(pchip->regmap,\n" ">> +\t\t\t\t REG_CL3_BRT_H,\n" ">> +\t\t\t\t (bl->props.brightness >> 8) & 0x1f);\n" - ">> +\t\tret |>> +\t\t regmap_write(pchip->regmap, REG_CL3_BRT_L,\n" + ">> +\t\tret |=\n" + ">> +\t\t regmap_write(pchip->regmap, REG_CL3_BRT_L,\n" ">> +\t\t\t\t bl->props.brightness & 0xff);\n" ">> +\t\tbreak;\n" ">> +\tdefault:\n" @@ -417,7 +420,7 @@ ">> +\n" ">> +\t/* register no. */\n" ">> +\ttok = strsep((char **)&buf, \" ,\\n\");\n" - ">> +\tif (tok = NULL)\n" + ">> +\tif (tok == NULL)\n" ">> +\t\tgoto err_input;\n" ">> +\tret = kstrtouint(tok, 16, ®);\n" ">> +\tif (ret)\n" @@ -425,7 +428,7 @@ ">> +\n" ">> +\t/* register value */\n" ">> +\ttok = strsep((char **)&buf, \" ,\\n\");\n" - ">> +\tif (tok = NULL)\n" + ">> +\tif (tok == NULL)\n" ">> +\t\tgoto err_input;\n" ">> +\tret = kstrtouint(tok, 16, &data);\n" ">> +\tif (ret)\n" @@ -516,7 +519,8 @@ ">> +\tprops.type = BACKLIGHT_RAW;\n" ">> +\tfor (icnt = LP8860_LED0; icnt < LP8860_LED_MAX; icnt++) {\n" ">> +\t\tprops.max_brightness = pdata->max_brt[icnt];\n" - ">> +\t\tpchip->bled[icnt] >> +\t\t backlight_device_register(lp8860_bled_name[icnt],\n" + ">> +\t\tpchip->bled[icnt] =\n" + ">> +\t\t backlight_device_register(lp8860_bled_name[icnt],\n" "> devm_* functions will make the code simpler.\n" "> Thus, please use devm_backlight_device_register(), instead of\n" "> backlight_device_register().\n" @@ -581,11 +585,11 @@ ">> +\t\treturn ret;\n" ">> +\t}\n" ">> +\n" - ">> +\tif (pdata = NULL) {\n" + ">> +\tif (pdata == NULL) {\n" ">> +\t\tpdata = devm_kzalloc(pchip->dev,\n" ">> +\t\t\t\t sizeof(struct lp8860_platform_data),\n" ">> +\t\t\t\t GFP_KERNEL);\n" - ">> +\t\tif (pdata = NULL)\n" + ">> +\t\tif (pdata == NULL)\n" ">> +\t\t\treturn -ENOMEM;\n" ">> +\t\tpdata->max_brt[LP8860_LED0] = 65535;\n" ">> +\t\tfor (icnt = LP8860_LED1; icnt < LP8860_LED_MAX; icnt++)\n" @@ -704,4 +708,4 @@ ">> --\n" >> 1.7.9.5 -39ed8342022096c1b798f074a9d71b337ec7e9c08ee683df2b31d0fe0c082042 +42ac2aa6681c2f896b24e656e75fc65fe2a266952f9a5b02db0c53ef272dab6f
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.