Re: [PATCH v2 4/4] ARM: DTS: AM43x: Add DSS node

[Sathya Prakash <a0393677@ti.com>]

On Thursday 13 March 2014 03:51 PM, Tomi Valkeinen wrote:
> On 13/03/14 10:58, Sathya Prakash M R wrote:
>> Add device node for DSS module for AM4372. Both the
>> AM437x-Gp evm and Am43x-Epos evm use the same LCD panel.
>> The lcd timings are added in respective dts files.
>> Adds display pinctrl and enables required gpio.
>> Also set the right parent clock to the DSS clock.
>>
>> Signed-off-by: Sathya Prakash M R <sathyap@ti.com>
>> ---
>>   arch/arm/boot/dts/am4372.dtsi        |   28 +++++++++++++
>>   arch/arm/boot/dts/am437x-gp-evm.dts  |   77 ++++++++++++++++++++++++++++++++++
>>   arch/arm/boot/dts/am43x-epos-evm.dts |   73 ++++++++++++++++++++++++++++++++
>>   arch/arm/boot/dts/am43xx-clocks.dtsi |    2 +
>>   4 files changed, 180 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
>> index ea55a4e..b72a7df 100644
>> --- a/arch/arm/boot/dts/am4372.dtsi
>> +++ b/arch/arm/boot/dts/am4372.dtsi
>> @@ -684,6 +684,34 @@
>>   			num-cs = <4>;
>>                           status = "disabled";
>>                   };
>> +
>> +		dss: dss@4832A000 {
>> +			compatible = "ti,omap3-dss", "simple-bus";
>> +			reg = <0x4832A000 0x200>;
>> +			ti,hwmods = "dss_core";
>> +			#address-cells = <1>;
>> +			#size-cells = <1>;
>> +			ranges;
>> +
>> +			dispc@4832A400 {
>> +				compatible = "ti,omap3-dispc";
>> +				reg = <0x4832A400 0x400>;
>> +				interrupts = <GIC_SPI 127 IRQ_TYPE_LEVEL_HIGH>;
>> +				ti,hwmods = "dss_dispc";
>> +			};
>> +
>> +			dpi: encoder@0 {
>> +				compatible = "ti,omap3-dpi";
>> +			};
>> +
>> +			rfbi: rfbi@4832A800 {
>> +				compatible = "ti,omap3-rfbi";
>> +			reg = <0x4832A800 0x100>;
>> +				ti,hwmods = "dss_rfbi";
>> +			};
>> +
>> +		};
>> +
> This seems to be based on old version of the DSS DT. Please rebase this
> on top of the latest one:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git work/dss-dt
Thanks. maybe i missed couple of changes. Will do that.
>
> You also need to split this into smaller pieces: the dts clock fix, the
> am4372.dtsi, and the board changes.
ok sure.
>
>   Tomi
>
>