From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42450)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WO4nl-0002OL-U7
	for qemu-devel@nongnu.org; Thu, 13 Mar 2014 08:32:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WO4ng-0005lW-GK
	for qemu-devel@nongnu.org; Thu, 13 Mar 2014 08:31:57 -0400
Received: from cantor2.suse.de ([195.135.220.15]:56895 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WO4ng-0005lB-Ab
	for qemu-devel@nongnu.org; Thu, 13 Mar 2014 08:31:52 -0400
Message-ID: <5321A52F.402@suse.de>
Date: Thu, 13 Mar 2014 13:31:43 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1394710307-13187-1-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1394710307-13187-1-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] libqtest: Avoid inline varargs functions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>, patches@linaro.org

Am 13.03.2014 12:31, schrieb Peter Maydell:
> Older versions of gcc (eg 4.6) can't handle varargs functions declared
> inline for anything other than completely trivial uses, and complain:
>=20
> tests/qom-test.c: In function 'qmp': tests/libqtest.h:359:60: sorry,
> unimplemented: function 'qmp' can never be inlined because it uses
> variable argument lists
>=20
> Avoid this problem by putting the functions into libqtest.c instead
> of using inline definitions in libqtest.h.
>=20
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Reviewed-by: Andreas F=E4rber <afaerber@suse.de>

Feel free to go ahead with this.

Thanks,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg