From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42851)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WO4pj-0004Xs-1J
	for qemu-devel@nongnu.org; Thu, 13 Mar 2014 08:34:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WO4pd-0006dk-1R
	for qemu-devel@nongnu.org; Thu, 13 Mar 2014 08:33:58 -0400
Received: from cantor2.suse.de ([195.135.220.15]:56914 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WO4pc-0006de-Rc
	for qemu-devel@nongnu.org; Thu, 13 Mar 2014 08:33:52 -0400
Message-ID: <5321A5AC.8050103@suse.de>
Date: Thu, 13 Mar 2014 13:33:48 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1394670436-575-1-git-send-email-afaerber@suse.de>
	<CAFEAcA_Li6PBeVYd1U3MaGEiaRv8K6ce1NNypcH8iO6TO_krHQ@mail.gmail.com>
In-Reply-To: <CAFEAcA_Li6PBeVYd1U3MaGEiaRv8K6ce1NNypcH8iO6TO_krHQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PULL for-2.0-rc0 v2 00/31] QOM devices patch
	queue 2014-03-12
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>, Anthony Liguori <anthony@codemonkey.ws>, "Michael S. Tsirkin" <mst@redhat.com>, Markus Armbruster <armbru@redhat.com>, Alexander Graf <agraf@suse.de>, QEMU Developers <qemu-devel@nongnu.org>, Bandan Das <bsd@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

Am 13.03.2014 12:22, schrieb Peter Maydell:
> On 13 March 2014 00:27, Andreas F=C3=A4rber <afaerber@suse.de> wrote:
>> Hello Peter,
>>
>> This is my QOM (devices) patch queue. Please pull.
>>
>> v2 changes qom-test.
>=20
> No, this is still broken:
> /home/petmay01/linaro/qemu-for-merges/tests/qom-test.c: In function =E2=
=80=98qmp=E2=80=99:
> /home/petmay01/linaro/qemu-for-merges/tests/libqtest.h:359:60: sorry,
> unimplemented: function =E2=80=98qmp=E2=80=99 can never be inlined beca=
use it uses
> variable argument lists
> make: *** [tests/qom-test.o] Error 1
> make: Leaving directory `/home/petmay01/linaro/qemu-for-merges/build/al=
l'
>=20
> Moving qmp() into libqtest.c and just having a
> prototype in libqtest.h (ie having it not be an
> inline varargs function) seems to fix this.
>=20
> I don't know why (a) it didn't complain about
> earlier uses of qmp() or (b) why it's not complaining
> about qmp_discard_response() now [perhaps the compiler
> manages to special case "varargs but the varargs list
> is empty]. Probably safest to move qmp_discard_response
> too, though.

My v1 did have empty varargs, so that's not it...

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg