From: Tom Musta <tommusta@gmail.com>
To: Richard Henderson <rth@twiddle.net>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/6] Refactor AES Instructions
Date: Thu, 13 Mar 2014 08:14:54 -0500 [thread overview]
Message-ID: <5321AF4E.8040909@gmail.com> (raw)
In-Reply-To: <5320E264.7030608@twiddle.net>
On 3/12/2014 5:40 PM, Richard Henderson wrote:
> On 03/10/2014 12:04 PM, Tom Musta wrote:
>> This patch series addresses concerns raised by Richard Henderson regarding redundant
>> copies of Advanced Encryption Standard (AES) data and code (see
>> http://lists.nongnu.org/archive/html/qemu-devel/2014-02/msg04391.html).
>>
>> The patches declare commonly used AES tables in the include/qemu/aes.h header file
>> and define the tables in util/aes.c, thus eliminating redundant copies.
>>
>> Minor refactorization of the i386 and ARM instruction models are made to utilize
>> this common support. The newly added PowerPC instructions are completely
>> rewritten and look much more like the i386 equivalents; a substantial amount of
>> code is eliminated.
>>
>> Tom Musta (6):
>> util: Add S-Box and InvS-Box Arrays to Common AES Utils
>> util: Add AES ShiftRows and InvShiftRows Tables
>> util: Add InvMixColumns
>> target-i386: Use Common ShiftRows and InvShiftRows Tables
>> target-arm: Use Common Tables in AES Instructions
>> target-ppc: Refactor AES Instructions
>
> Other than the one nit,
>
> Reviewed-by: Richard Henderson <rth@twiddle.net>
>
>
> r~
>
Thanks. I will rework the nit and republish a V2.
prev parent reply other threads:[~2014-03-13 13:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 19:04 [Qemu-devel] [PATCH 0/6] Refactor AES Instructions Tom Musta
2014-03-10 19:04 ` [Qemu-devel] [PATCH 1/6] util: Add S-Box and InvS-Box Arrays to Common AES Utils Tom Musta
2014-03-10 19:04 ` [Qemu-devel] [PATCH 2/6] util: Add AES ShiftRows and InvShiftRows Tables Tom Musta
2014-03-10 19:04 ` [Qemu-devel] [PATCH 3/6] util: Add InvMixColumns Tom Musta
2014-03-10 19:05 ` [Qemu-devel] [PATCH 4/6] target-i386: Use Common ShiftRows and InvShiftRows Tables Tom Musta
2014-03-10 19:05 ` [Qemu-devel] [PATCH 5/6] target-arm: Use Common Tables in AES Instructions Tom Musta
2014-03-12 22:37 ` Richard Henderson
2014-03-10 19:05 ` [Qemu-devel] [PATCH 6/6] target-ppc: Refactor " Tom Musta
2014-03-12 22:40 ` [Qemu-devel] [PATCH 0/6] " Richard Henderson
2014-03-13 13:14 ` Tom Musta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5321AF4E.8040909@gmail.com \
--to=tommusta@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.