From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] blockdev: Refuse to open encrypted image unless paused
Date: Thu, 13 Mar 2014 15:14:59 +0100 [thread overview]
Message-ID: <5321BD63.8010007@redhat.com> (raw)
In-Reply-To: <87a9cuw81r.fsf@blackfin.pond.sub.org>
Il 13/03/2014 14:18, Markus Armbruster ha scritto:
> Paolo Bonzini <pbonzini@redhat.com> writes:
>
>> Il 12/03/2014 18:00, Markus Armbruster ha scritto:
>>> + } else if (!runstate_check(RUN_STATE_PRELAUNCH)
>>> + && !runstate_check(RUN_STATE_PAUSED)) { /* HACK */
>>
>> Why not "if (runstate_is_running())"?
>
> The predicate actually wanted here is "monitor command 'cont' required
> to get the guest running", because 'cont' is where the protection is.
> My run state test is a crude approximation.
>
Got it. Then you need to add at least a check for
"runstate_check(RUN_STATE_INMIGRATE)", otherwise you break incoming
migration. Actually, I think only SAVE_VM/RESTORE_VM/DEBUG are
problematic, but I understand why you preferred a conservative
test (sufficient condition, not necessary).
You are singling out prelaunch and inmigrate because drive_init
will reset autostart to 0 for an encrypted image, right?
Paolo
next prev parent reply other threads:[~2014-03-13 14:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 17:00 [Qemu-devel] [PATCH] blockdev: Refuse to open encrypted image unless paused Markus Armbruster
2014-03-12 17:19 ` Eric Blake
2014-03-13 9:26 ` Fam Zheng
2014-03-13 13:25 ` Markus Armbruster
2014-03-14 1:13 ` Fam Zheng
2014-03-14 8:16 ` Markus Armbruster
2014-03-13 10:43 ` Paolo Bonzini
2014-03-13 13:18 ` Markus Armbruster
2014-03-13 14:14 ` Paolo Bonzini [this message]
2014-03-13 15:00 ` Markus Armbruster
2014-03-13 15:08 ` Paolo Bonzini
2014-03-14 8:15 ` Markus Armbruster
2014-03-13 13:27 ` Eric Blake
2014-03-13 14:19 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5321BD63.8010007@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.