All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] main-loop: Suppress "I/O thread spun" warnings for qtest
Date: Thu, 13 Mar 2014 15:19:36 +0100	[thread overview]
Message-ID: <5321BE78.7050306@suse.de> (raw)
In-Reply-To: <1394720249-13318-1-git-send-email-peter.maydell@linaro.org>

Am 13.03.2014 15:17, schrieb Peter Maydell:
> When running under qtest we don't actually have any vcpu threads
> to be starved, so the warning about the I/O thread spinning isn't
> relevant, and the way qtest manipulates the simulated clock means
> the warning is produced a lot as a false positive. Suppress it if
> qtest_enabled(), so 'make check' output is less noisy.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  main-loop.c         |  3 ++-
>  stubs/Makefile.objs |  1 +
>  stubs/qtest.c       | 14 ++++++++++++++
>  3 files changed, 17 insertions(+), 1 deletion(-)
>  create mode 100644 stubs/qtest.c

Looks OK to me, a bit unfortunate that we need a stub, but

Reviewed-by: Andreas Färber <afaerber@suse.de>

Thanks,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

  reply	other threads:[~2014-03-13 14:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-13 14:17 [Qemu-devel] [PATCH] main-loop: Suppress "I/O thread spun" warnings for qtest Peter Maydell
2014-03-13 14:19 ` Andreas Färber [this message]
2014-03-13 17:43 ` Stefan Hajnoczi
2014-03-13 20:39 ` Andreas Färber
2014-03-14  0:18   ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5321BE78.7050306@suse.de \
    --to=afaerber@suse.de \
    --cc=patches@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.