From: Lars-Peter Clausen <lars@metafoo.de>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@sirena.org.uk>,
Jyri Sarha <jsarha@ti.com>, Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: ASoC updates for v3.15
Date: Thu, 13 Mar 2014 16:31:30 +0100 [thread overview]
Message-ID: <5321CF52.1070708@metafoo.de> (raw)
In-Reply-To: <s5hd2hqxiz4.wl%tiwai@suse.de>
On 03/13/2014 03:37 PM, Takashi Iwai wrote:
[...]
> Something broken in this update. Now I get the build errors:
>
> CC [M] sound/soc/codecs/tlv320aic31xx.o
> sound/soc/codecs/tlv320aic31xx.c: In function ‘aic31xx_clk_off’:
> sound/soc/codecs/tlv320aic31xx.c:946:23: warning: unused variable ‘aic31xx’ [-Wunused-variable]
> struct aic31xx_priv *aic31xx = snd_soc_codec_get_drvdata(codec);
> ^
> sound/soc/codecs/tlv320aic31xx.c: In function ‘aic31xx_codec_probe’:
> sound/soc/codecs/tlv320aic31xx.c:1057:48: error: ‘SND_SOC_REGMAP’ undeclared (first use in this function)
> ret = snd_soc_codec_set_cache_io(codec, 8, 8, SND_SOC_REGMAP);
> ^
> sound/soc/codecs/tlv320aic31xx.c:1057:48: note: each undeclared identifier is reported only once for each function it appears in
> sound/soc/codecs/tlv320aic31xx.c:1057:2: warning: passing argument 2 of ‘snd_soc_codec_set_cache_io’ makes pointer from integer without a cast [enabled by default]
> ret = snd_soc_codec_set_cache_io(codec, 8, 8, SND_SOC_REGMAP);
> ^
> In file included from sound/soc/codecs/tlv320aic31xx.c:36:0:
> include/sound/soc.h:402:5: note: expected ‘struct regmap *’ but argument is of type ‘int’
> int snd_soc_codec_set_cache_io(struct snd_soc_codec *codec,
> ^
> sound/soc/codecs/tlv320aic31xx.c:1057:2: error: too many arguments to function ‘snd_soc_codec_set_cache_io’
> ret = snd_soc_codec_set_cache_io(codec, 8, 8, SND_SOC_REGMAP);
> ^
> In file included from sound/soc/codecs/tlv320aic31xx.c:36:0:
> include/sound/soc.h:402:5: note: declared here
> int snd_soc_codec_set_cache_io(struct snd_soc_codec *codec,
> ^
> make[3]: *** [sound/soc/codecs/tlv320aic31xx.o] Error 1
Adding Jyri to Cc. Jyri can you send a patch that fixes this up? There was a
overlap between your patch and a cleanup that changed the signature of
snd_soc_codec_set_cache_io(). Note that you can just drop both the
control_data assignment and the snd_soc_codec_set_cache_io() call from your
codec probe function since this is now done automatically by the core.
- Lars
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2014-03-13 15:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 14:29 ASoC updates for v3.15 Mark Brown
2014-03-13 14:37 ` Takashi Iwai
2014-03-13 15:31 ` Lars-Peter Clausen [this message]
2014-03-13 16:13 ` Jyri Sarha
-- strict thread matches above, loose matches on Subject: below --
2014-04-09 14:39 Mark Brown
2014-04-09 15:52 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5321CF52.1070708@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@sirena.org.uk \
--cc=jsarha@ti.com \
--cc=lgirdwood@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.