From: Michael Haggerty <mhagger@alum.mit.edu>
To: Quint Guvernator <quintus.public@gmail.com>
Cc: Duy Nguyen <pclouds@gmail.com>, Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] general style: replaces memcmp() with starts_with()
Date: Thu, 13 Mar 2014 17:05:47 +0100 [thread overview]
Message-ID: <5321D75B.5020600@alum.mit.edu> (raw)
In-Reply-To: <CALs4jVFM58Yiku4B8NrVeac0Hmt5YsPNYb_EjY6bOr=JO6pP+A@mail.gmail.com>
On 03/12/2014 03:06 PM, Quint Guvernator wrote:
> 2014-03-12 9:51 GMT-04:00 Duy Nguyen <pclouds@gmail.com>:
>> starts_with(..) == !memcmp(...). So
>> you need to negate every replacement.
>
> My apologies--it doesn't look like the tests caught it either. I will
> fix this and submit a new patch.
It is very, very unlikely that you inverted the sense of dozens of tests
throughout the Git code base and the tests ran correctly. I rather
think that you made a mistake when testing. You should double- and
triple-check that you really ran the tests and ran them correctly.
Michael
--
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/
next prev parent reply other threads:[~2014-03-13 16:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 13:44 [PATCH] general style: replaces memcmp() with starts_with() Quint Guvernator
2014-03-12 13:51 ` Duy Nguyen
2014-03-12 14:06 ` Quint Guvernator
2014-03-13 16:05 ` Michael Haggerty [this message]
2014-03-14 16:32 ` Quint Guvernator
2014-03-12 15:47 ` Jens Lehmann
2014-03-12 16:46 ` Quint Guvernator
2014-03-12 17:22 ` Jens Lehmann
2014-03-12 18:00 ` Jeff King
2014-03-12 23:26 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5321D75B.5020600@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=quintus.public@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.