Andrew Cooper wrote: > > Also include #defines for the test code to allow compilation. > > Signed-off-by: Andrew Cooper > CC: Keir Fraser > CC: Jan Beulich > CC: Ian Campbell > CC: Ian Jackson > > --- > > I have mixed thoughts about this, which is why it is explicit > separated from > the rest of the series. On the one hand, consistency is good but on the > other, it makes x86_emulate harder to use as a dropin in other code. We already have a bunch of external definitions that must be provided for x86_emulate.c. This merely adds another, but which is required for x86_emulate.h. So it's perfectly fine by me. Acked-by: Keir Fraser