Re: [Qemu-devel] [PULL 0/7] gtk: cleanups and fixes

[Cole Robinson <crobinso@redhat.com>]

On 03/13/2014 02:55 PM, Peter Maydell wrote:
> On 13 March 2014 10:46, Gerd Hoffmann <kraxel@redhat.com> wrote:
>>   Hi,
>>
>> Looks like I've became the default victim for gtk patches, with anthony
>> being busy and /me recently picking up the gtk mouse wheel patch.
>>
>> So here is a collection of gtk patches hitting my inbox over the last
>> few days.  Not strictly bugfixes-only, but the cleanups are simple
>> enouth that I think they are fine for 2.0.
>>
>> please pull,
>>   Gerd
>>
>> The following changes since commit 239618707637ec87eba8c452d2b2f75dc5ca20c7:
>>
>>   Merge remote-tracking branch 'remotes/kvm/uq/master' into staging (2014-03-11 19:39:17 +0000)
>>
>> are available in the git repository at:
>>
>>
>>   git://git.kraxel.org/qemu tags/pull-gtk-1
>>
>> for you to fetch changes up to 1962744467ec5624bfecb55bf5a2c321744da253:
>>
>>   gtk: Don't warp absolute pointer (2014-03-13 10:12:47 +0100)
> 
> Doesn't build, sorry:
> 
> /home/petmay01/linaro/qemu-for-merges/ui/gtk.c: In function ‘gd_vc_init’:
> /home/petmay01/linaro/qemu-for-merges/ui/gtk.c:1206:5: error: implicit
> declaration of function ‘gtk_scrollable_get_vadjustment’
> [-Werror=implicit-function-declaration]
> /home/petmay01/linaro/qemu-for-merges/ui/gtk.c:1206:5: error: nested
> extern declaration of ‘gtk_scrollable_get_vadjustment’
> [-Werror=nested-externs]
> /home/petmay01/linaro/qemu-for-merges/ui/gtk.c:1206:5: error: implicit
> declaration of function ‘GTK_SCROLLABLE’
> [-Werror=implicit-function-declaration]
> /home/petmay01/linaro/qemu-for-merges/ui/gtk.c:1206:5: error: nested
> extern declaration of ‘GTK_SCROLLABLE’ [-Werror=nested-externs]
> /home/petmay01/linaro/qemu-for-merges/ui/gtk.c:1206:17: error:
> assignment makes pointer from integer without a cast [-Werror]
> cc1: all warnings being treated as errors
> make: *** [ui/gtk.o] Error 1
> 

Hmm, gtkscrollable is gtk3 only, I'll test building against gtk2 and respin.
Sorry for the run around.

- Cole