From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-la0-f42.google.com ([209.85.215.42]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WOBo6-0005lJ-OS for linux-mtd@lists.infradead.org; Thu, 13 Mar 2014 20:00:47 +0000 Received: by mail-la0-f42.google.com with SMTP id ec20so1072159lab.29 for ; Thu, 13 Mar 2014 13:00:24 -0700 (PDT) Message-ID: <53221AD4.3090002@cogentembedded.com> Date: Thu, 13 Mar 2014 23:53:40 +0300 From: Sergei Shtylyov MIME-Version: 1.0 To: Ezequiel Garcia , Mike Turquette , Jason Cooper , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mtd@lists.infradead.org Subject: Re: [PATCH v2 5/6] ARM: mvebu: Enable NAND controller in Armada 385-DB References: <1394739542-30017-1-git-send-email-ezequiel@vanguardiasur.com.ar> <1394739542-30017-6-git-send-email-ezequiel@vanguardiasur.com.ar> In-Reply-To: <1394739542-30017-6-git-send-email-ezequiel@vanguardiasur.com.ar> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Lior Amsalem , Thomas Petazzoni , Tawfik Bayouk , Andrew Lunn , Seif Mazareeb , Ezequiel Garcia , Gregory Clement , Sebastian Hesselbarth List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 03/13/2014 10:39 PM, Ezequiel Garcia wrote: > From: Ezequiel Garcia > The Armada 385-DB board has a NAND flash, so enable it in the > devicetree and add the partitions as prepared in the factory images. > Signed-off-by: Ezequiel Garcia > --- > arch/arm/boot/dts/armada-385-db.dts | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > diff --git a/arch/arm/boot/dts/armada-385-db.dts b/arch/arm/boot/dts/armada-385-db.dts > index 9a13642..edcf7ff 100644 > --- a/arch/arm/boot/dts/armada-385-db.dts > +++ b/arch/arm/boot/dts/armada-385-db.dts > @@ -80,6 +80,27 @@ > reg = <1>; > }; > }; > + > + flash: flash@d0000 { Note that you don't have to label your device the same way as it's named, i.e. you could have labelled it "nand" if it would make things clearer. Although I don't readily see the value of labeling nodes in the board's .dts file. Do you really expect to refer to it somewhere? WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov) Date: Thu, 13 Mar 2014 23:53:40 +0300 Subject: [PATCH v2 5/6] ARM: mvebu: Enable NAND controller in Armada 385-DB In-Reply-To: <1394739542-30017-6-git-send-email-ezequiel@vanguardiasur.com.ar> References: <1394739542-30017-1-git-send-email-ezequiel@vanguardiasur.com.ar> <1394739542-30017-6-git-send-email-ezequiel@vanguardiasur.com.ar> Message-ID: <53221AD4.3090002@cogentembedded.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 03/13/2014 10:39 PM, Ezequiel Garcia wrote: > From: Ezequiel Garcia > The Armada 385-DB board has a NAND flash, so enable it in the > devicetree and add the partitions as prepared in the factory images. > Signed-off-by: Ezequiel Garcia > --- > arch/arm/boot/dts/armada-385-db.dts | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > diff --git a/arch/arm/boot/dts/armada-385-db.dts b/arch/arm/boot/dts/armada-385-db.dts > index 9a13642..edcf7ff 100644 > --- a/arch/arm/boot/dts/armada-385-db.dts > +++ b/arch/arm/boot/dts/armada-385-db.dts > @@ -80,6 +80,27 @@ > reg = <1>; > }; > }; > + > + flash: flash at d0000 { Note that you don't have to label your device the same way as it's named, i.e. you could have labelled it "nand" if it would make things clearer. Although I don't readily see the value of labeling nodes in the board's .dts file. Do you really expect to refer to it somewhere? WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH v2 5/6] ARM: mvebu: Enable NAND controller in Armada 385-DB Date: Thu, 13 Mar 2014 23:53:40 +0300 Message-ID: <53221AD4.3090002@cogentembedded.com> References: <1394739542-30017-1-git-send-email-ezequiel@vanguardiasur.com.ar> <1394739542-30017-6-git-send-email-ezequiel@vanguardiasur.com.ar> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1394739542-30017-6-git-send-email-ezequiel-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ezequiel Garcia , Mike Turquette , Jason Cooper , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Cc: Lior Amsalem , Tawfik Bayouk , Seif Mazareeb , Thomas Petazzoni , Gregory Clement , Andrew Lunn , Sebastian Hesselbarth , Ezequiel Garcia List-Id: devicetree@vger.kernel.org On 03/13/2014 10:39 PM, Ezequiel Garcia wrote: > From: Ezequiel Garcia > The Armada 385-DB board has a NAND flash, so enable it in the > devicetree and add the partitions as prepared in the factory images. > Signed-off-by: Ezequiel Garcia > --- > arch/arm/boot/dts/armada-385-db.dts | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > diff --git a/arch/arm/boot/dts/armada-385-db.dts b/arch/arm/boot/dts/armada-385-db.dts > index 9a13642..edcf7ff 100644 > --- a/arch/arm/boot/dts/armada-385-db.dts > +++ b/arch/arm/boot/dts/armada-385-db.dts > @@ -80,6 +80,27 @@ > reg = <1>; > }; > }; > + > + flash: flash@d0000 { Note that you don't have to label your device the same way as it's named, i.e. you could have labelled it "nand" if it would make things clearer. Although I don't readily see the value of labeling nodes in the board's .dts file. Do you really expect to refer to it somewhere? WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html