From: Robert Yang <liezhi.yang@windriver.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 3/6] package_rpm.bbclass: archive the source to srpm package
Date: Fri, 14 Mar 2014 10:14:00 +0800 [thread overview]
Message-ID: <532265E8.1010907@windriver.com> (raw)
In-Reply-To: <CAJTo0LYPyrTpEN6w4g5KcmsXMB6=GvaKxcshObb1Co6Lh3A8VA@mail.gmail.com>
On 03/14/2014 01:39 AM, Burton, Ross wrote:
> On 11 March 2014 17:08, Robert Yang <liezhi.yang@windriver.com> wrote:
>> - # Remove the source (SOURCE0, SOURCE1 ...)
>> - cmd = cmd + " --rmsource "
>
> You probably want to keep this as otherwise
> deploy/sources/MACHINE/RECIPE/ contains both the .src.rpm and the
> separate sources.
>
I'd like to remove the sources in the first thought, but that would
cause a problem: if we only re-run the do_package_write_rpm, for example,
when the FILES is changed, then the sources are gone, and we would get
nothing in the .src.rpm. I thing that keep both the .src.rpm and.tar.gz
is not a big problem, so I changed the usage to:
We will always get .tar.gz and other sources, and the .src.rpm is optional:
ARCHIVER_MODE[srpm] ?= "1"
I think that we can move the rpmbuild related code to archiver.*bbclass to
fix the problem, but that would change a lot of the code, I'd like to fix
it in the next release:-)
// Robert
> Ross
>
>
next prev parent reply other threads:[~2014-03-14 2:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 17:08 [PATCH 0/6 V3] refactor the archiver*.bbclass Robert Yang
2014-03-11 17:08 ` [PATCH 1/6] classes/archive*.bbclass: remove archive-*-source.bbclass Robert Yang
2014-03-11 17:08 ` [PATCH 2/6] archiver.bbclass: refactor it Robert Yang
2014-03-19 12:12 ` Paul Eggleton
2014-03-20 1:22 ` Robert Yang
2014-03-20 7:38 ` Robert Yang
2014-03-11 17:08 ` [PATCH 3/6] package_rpm.bbclass: archive the source to srpm package Robert Yang
2014-03-13 17:39 ` Burton, Ross
2014-03-14 2:14 ` Robert Yang [this message]
2014-03-14 10:59 ` Burton, Ross
2014-03-11 17:08 ` [PATCH 4/6] archiver.bbclass: move a few code to copyleft_compliance.bbclass Robert Yang
2014-03-19 12:09 ` Paul Eggleton
2014-03-20 1:18 ` Robert Yang
2014-03-11 17:08 ` [PATCH 5/6] local.conf.sample.extended: update for the archiver Robert Yang
2014-03-11 17:08 ` [PATCH 6/6] patch.bbclass: do_patch: unset TMPDIR from environment Robert Yang
2014-03-13 16:46 ` Burton, Ross
2014-03-13 16:54 ` Burton, Ross
2014-03-13 18:11 ` Chris Larson
2014-03-14 10:17 ` Robert Yang
2014-03-13 17:45 ` [PATCH 0/6 V3] refactor the archiver*.bbclass Burton, Ross
2014-03-14 15:03 ` Robert Yang
2014-03-21 17:03 ` Richard Purdie
2014-03-19 12:14 ` Paul Eggleton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532265E8.1010907@windriver.com \
--to=liezhi.yang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.