Re: [PATCH 1/3] libselinux: Evaluate inodes in selinux_restorecon(3)

[Richard Haines <richard_c_haines@btinternet.com>]

> On Friday, 20 May 2016, 17:24, Stephen Smalley <sds@tycho.nsa.gov> wrote:
> > On 05/10/2016 11:22 AM, Richard Haines wrote:
>>  This patch transfers matchpathcon.c inode evaluation services to
>>  selinux_restorecon.c and modifies them to also support setfiles(8)
>>  inode services.
>> 
>>  The overall objective is to modify restorecon(8) and setfiles(8)
>>  to use selinux_restorecon(3) services and then, when ready
>>  remove the deprecated matchpathcon services from libselinux.
>> 
>>  Signed-off-by: Richard Haines <richard_c_haines@btinternet.com>
>>  ---
>>   libselinux/include/selinux/restorecon.h  |   4 +
>>   libselinux/man/man3/selinux_restorecon.3 |   5 +-
>>   libselinux/src/matchpathcon.c            | 139 +------------
>>   libselinux/src/selinux_restorecon.c      | 333 
> ++++++++++++++++++++++++++++---
>>   libselinux/utils/selinux_restorecon.c    |  14 +-
>>   5 files changed, 330 insertions(+), 165 deletions(-)

>> 

----- snip ------
> 
> Maybe we ought to just leave the matchpathcon ones alone (aside from
> deprecating and ultimately removing them), and bring over the versions
> added to setfiles when it was converted to using selabel_open().

> 

I'll leave matchpathcon alone and port over the setfiles code.