From mboxrd@z Thu Jan 1 00:00:00 1970 From: Normand Subject: oprofile-0.9.7-xen.patch make oprofile build failure for powerpc Date: Fri, 14 Mar 2014 07:23:33 +0100 Message-ID: <5322A065.4060007@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------030107090003000100040607" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xensource.com Cc: wcohen@redhat.com List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --------------030107090003000100040607 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Trying to build oprofile on fedora that is using the oprofile-0.9.7-xen.patch the build is failing on ppc64le archi with: === gcc -DHAVE_CONFIG_H -I. -I.. -I ../libabi -I ../libutil -I ../libop -I ../libdb -W -Wall -fno-common -Wdeclaration-after-statement -Werror -fno-omit-frame-pointer -O2 -g -fsigned-char -c -o opd_trans.o opd_trans.c opd_trans.c:270:13: error: 'code_domain_switch' defined but not used [-Werror=unused-function] static void code_domain_switch(struct transient *trans) === I do not know who is in charge to keep this patch updated, but I would suggest to fold it with following attached patch. -- Michel Normand --------------030107090003000100040607 Content-Type: text/x-diff; name="oprofile_no_code_domain_switch.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="oprofile_no_code_domain_switch.patch" >>From c5c73e871bfe9b0ccbc97cd12ff55a53018ce889 Mon Sep 17 00:00:00 2001 From: Michel Normand Date: Thu, 13 Mar 2014 09:59:18 -0500 Subject: [PATCH] code_domain_switch function not to be defined for powerpc the code_domain_switch function added by xen patch is not used in powerpc environment and its presence make the build to fail. So add an additionnal patch to not define the function if powerpc environment. Signed-off-by: Michel Normand diff --git a/oprofile.opd_trans.not_used_code_domain_switch.patch b/oprofile.opd_trans.not_used_code_domain_switch.patch new file mode 100644 index 0000000..7ed08d3 --- /dev/null +++ b/oprofile.opd_trans.not_used_code_domain_switch.patch @@ -0,0 +1,29 @@ +Subject: oprofile opd_trans.c not using code_domain_switch +From: Michel Normand + +The code_domain_switch static function is not used for powerpc env +so disable it for that environment. + +Signed-off-by: Michel Normand +Index: oprofile-0.9.9/daemon/opd_trans.c +=================================================================== +--- oprofile-0.9.9.orig/daemon/opd_trans.c ++++ oprofile-0.9.9/daemon/opd_trans.c +@@ -267,6 +267,7 @@ static void code_xen_enter(struct transi + * meaningless for Xen - same reason as for kernel */ + } + ++#if ! defined(__powerpc__) + static void code_domain_switch(struct transient *trans) + { + /* While processing passive domain samples we ensure (in_kernel!=0) +@@ -285,7 +286,8 @@ static void code_domain_switch(struct tr + if (current_domain == COORDINATOR_DOMAIN) + trans->in_kernel--; + } +- ++#endif ++ + extern void code_spu_profiling(struct transient * trans); + extern void code_spu_ctx_switch(struct transient * trans); + diff --git a/oprofile.spec b/oprofile.spec index e5ccc81..2418604 100644 --- a/oprofile.spec +++ b/oprofile.spec @@ -12,6 +12,7 @@ Requires(pre): shadow-utils Requires(postun): shadow-utils Patch10: oprofile-0.4-guess2.patch Patch83: oprofile-0.9.7-xen.patch +Patch84: oprofile.opd_trans.not_used_code_domain_switch.patch URL: http://oprofile.sf.net @@ -76,6 +77,7 @@ agent library. %setup -q -n %{name}-%{version} %patch10 -p1 -b .guess2 %patch83 -p1 -b .xen +%patch84 -p1 ./autogen.sh --------------030107090003000100040607 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --------------030107090003000100040607--