From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tero Kristo Subject: Re: [RFC 2/5] ARM: dts: am33xx: Set parent clock for timer through DT Date: Fri, 14 Mar 2014 10:08:59 +0200 Message-ID: <5322B91B.4020401@ti.com> References: <1394742919-32163-1-git-send-email-joelf@ti.com> <1394742919-32163-3-git-send-email-joelf@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1394742919-32163-3-git-send-email-joelf@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Joel Fernandes , Tony Lindgren , Rob Herring , Nishanth Menon , Suman Anna , Felipe Balbi Cc: Linux OMAP List , Linux ARM Kernel List , Linux Kernel Mailing List List-Id: linux-omap@vger.kernel.org On 03/13/2014 10:35 PM, Joel Fernandes wrote: > Signed-off-by: Joel Fernandes > --- > arch/arm/boot/dts/am33xx.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi > index 4e6c959..51b7008 100644 > --- a/arch/arm/boot/dts/am33xx.dtsi > +++ b/arch/arm/boot/dts/am33xx.dtsi > @@ -352,6 +352,7 @@ > interrupts = <67>; > ti,hwmods = "timer1"; > ti,timer-alwon; > + ti,default-parent = <&sys_clkin_ck>; > }; > > timer2: timer@48040000 { > @@ -360,6 +361,7 @@ > reg = <0x48040000 0x400>; > interrupts = <68>; > ti,hwmods = "timer2"; > + ti,default-parent = <&sys_clkin_ck>; > }; > > timer3: timer@48042000 { > I don't think this works, the ti,default-parent property is only supported for clock nodes (at least I didn't quickly find anything from your clocksource driver that would handle this.) You should do something like this: &timer1_fck { ti,default-parent = <&sys_clkin_ck>; }; &timer2_fck { ti,default-parent = <&sys_clkin_ck>; }; -Tero From mboxrd@z Thu Jan 1 00:00:00 1970 From: t-kristo@ti.com (Tero Kristo) Date: Fri, 14 Mar 2014 10:08:59 +0200 Subject: [RFC 2/5] ARM: dts: am33xx: Set parent clock for timer through DT In-Reply-To: <1394742919-32163-3-git-send-email-joelf@ti.com> References: <1394742919-32163-1-git-send-email-joelf@ti.com> <1394742919-32163-3-git-send-email-joelf@ti.com> Message-ID: <5322B91B.4020401@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 03/13/2014 10:35 PM, Joel Fernandes wrote: > Signed-off-by: Joel Fernandes > --- > arch/arm/boot/dts/am33xx.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi > index 4e6c959..51b7008 100644 > --- a/arch/arm/boot/dts/am33xx.dtsi > +++ b/arch/arm/boot/dts/am33xx.dtsi > @@ -352,6 +352,7 @@ > interrupts = <67>; > ti,hwmods = "timer1"; > ti,timer-alwon; > + ti,default-parent = <&sys_clkin_ck>; > }; > > timer2: timer at 48040000 { > @@ -360,6 +361,7 @@ > reg = <0x48040000 0x400>; > interrupts = <68>; > ti,hwmods = "timer2"; > + ti,default-parent = <&sys_clkin_ck>; > }; > > timer3: timer at 48042000 { > I don't think this works, the ti,default-parent property is only supported for clock nodes (at least I didn't quickly find anything from your clocksource driver that would handle this.) You should do something like this: &timer1_fck { ti,default-parent = <&sys_clkin_ck>; }; &timer2_fck { ti,default-parent = <&sys_clkin_ck>; }; -Tero