From: Lars-Peter Clausen <lars@metafoo.de>
To: Jyri Sarha <jsarha@ti.com>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
linaro-kernel@lists.linaro.org, Mark Brown <broonie@linaro.org>
Subject: Re: [PATCH] ASoC: tlv320aic31xx: Staticise non-exported symbols
Date: Fri, 14 Mar 2014 09:31:44 +0100 [thread overview]
Message-ID: <5322BE70.9030809@metafoo.de> (raw)
In-Reply-To: <5322B93C.8080403@ti.com>
On 03/14/2014 09:09 AM, Jyri Sarha wrote:
> On 03/13/2014 07:48 PM, Mark Brown wrote:
>> From: Mark Brown <broonie@linaro.org>
>>
>> Signed-off-by: Mark Brown <broonie@linaro.org>
>
>
> Acked-by: Jyri Sarha <jsarha@it.com>
>
> /me has added one more thing to his patch sending check list.
What I typically try to do before submitting a patch is run
make C=2 .../driver.o
make C=2 CHECK=scripts/coccicheck .../driver.o
make C=2 CHECK="smatch --full-path -p=kernel" .../driver.o
that will typically catch these little mistakes. Also of course
scripts/checkpatch.pl on the patch itself.
- Lars
next prev parent reply other threads:[~2014-03-14 8:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 17:48 [PATCH] ASoC: tlv320aic31xx: Staticise non-exported symbols Mark Brown
2014-03-14 8:09 ` Jyri Sarha
2014-03-14 8:31 ` Lars-Peter Clausen [this message]
2014-03-14 10:23 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5322BE70.9030809@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=broonie@linaro.org \
--cc=jsarha@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linaro-kernel@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.