Re: [PATCH 1/1] dbus: fix a hard dependency about dbus-ptest

[Chong Lu <Chong.Lu@windriver.com>]

On 03/13/2014 06:01 PM, Paul Eggleton wrote:
> On Thursday 13 March 2014 17:54:03 Chong Lu wrote:
>> On 03/06/2014 06:04 PM, Burton, Ross wrote:
>>> On 6 March 2014 08:06, Chong Lu <Chong.Lu@windriver.com> wrote:
>>>> +PACKAGES += "dbus-ptest"
>>>> +ALLOW_EMPTY_${PN}-ptest = "1"
>>>> +RDEPENDS_${PN}-ptest = "${@base_contains('IMAGE_FEATURES', 'ptest-pkgs',
>>>> 'dbus-test-ptest', 'dbus-test', d)}"
>>> Clearly I wasn't thinking clearly last week.  You can't check
>>> IMAGE_FEATURES in a non-image recipe so this isn't a good solution.
>> Do you have any suggestion about this issue?
>> If we don't check IMAGE_FEATURES, I have no way to resolve this problem
>> that only build but not install ptest. I'm very confused.
> This should check DISTRO_FEATURES, not IMAGE_FEATURES. Assuming ptest is in
> DISTRO_FEATURES, even if ptest is not in IMAGE_FEATURES it doesn't matter if
> the dependency between dbus-ptest and dbus-ptest-ptest exists because dbus-
> ptest itself shouldn't be in the image, so dbus-ptest-ptest shouldn't be
> pulled in either. Does that make sense?
>
> Cheers,
> Paul
>
Hi Paul,

Thanks for your reply!
But I still have a question.

I try to following way:

# git diff
diff --git a/meta/recipes-core/dbus/dbus-ptest_1.6.18.bb 
b/meta/recipes-core/dbus/dbus-ptest_1.6.18.bb
index bc260de..50dfe54 100644
--- a/meta/recipes-core/dbus/dbus-ptest_1.6.18.bb
+++ b/meta/recipes-core/dbus/dbus-ptest_1.6.18.bb
@@ -9,6 +9,7 @@ DEPENDS = "python-pygobject dbus dbus-glib"

  RDEPENDS_${PN} += "make"
  RDEPENDS_${PN}-dev = ""
+ALLOW_EMPTY_${PN} = "1"

  SRC_URI = "http://dbus.freedesktop.org/releases/dbus/dbus-${PV}.tar.gz \
             file://tmpdir.patch \
diff --git a/meta/recipes-core/dbus/dbus.inc 
b/meta/recipes-core/dbus/dbus.inc
index 677ff78..ba7f3cb 100644
--- a/meta/recipes-core/dbus/dbus.inc
+++ b/meta/recipes-core/dbus/dbus.inc
@@ -6,7 +6,7 @@ LICENSE = "AFL-2 | GPLv2+"
  LIC_FILES_CHKSUM = "file://COPYING;md5=10dded3b58148f3f1fd804b26354af3e \
file://dbus/dbus.h;beginline=6;endline=20;md5=7755c9d7abccd5dbd25a6a974538bb3c"
  DEPENDS = "expat virtual/libintl"
-RDEPENDS_dbus = "${@base_contains('DISTRO_FEATURES', 'ptest', 
'dbus-ptest-ptest', '', d)}"
+RDEPENDS_dbus = "dbus-ptest"
  RDEPENDS_dbus_class-native = ""
  RDEPENDS_dbus_class-nativesdk = ""

In local.conf, I set following thing:
+EXTRA_IMAGE_FEATURES += "ptest-pkgs"
+CORE_IMAGE_EXTRA_INSTALL += "dbus"

Then, I run "bitbake core-image-minimal" command.
Finally, I start target through runqemu.
But dbus ptest is not installed.

I alway try to many ways to fix this issue, but the result is not 
satisfactory.

I think the point of this defect is the following question:
If we only want to build dbus-ptest (generate dbus-ptest-ptest-***.rpm), 
but not install it. How to resolve it?

Best Regards
Chong