From: Lai Jiangshan <laijs@cn.fujitsu.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Keir Fraser <keir.fraser@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH 5/5] xc_save: simplify switch_qemu_logdirty() by use stack strings
Date: Fri, 14 Mar 2014 17:21:14 +0800 [thread overview]
Message-ID: <5322CA0A.3000703@cn.fujitsu.com> (raw)
In-Reply-To: <21281.58066.375826.21774@mariner.uk.xensource.com>
On 03/14/2014 12:54 AM, Ian Jackson wrote:
> Lai Jiangshan writes ("[PATCH 5/5] xc_save: simplify switch_qemu_logdirty() by use stack strings"):
>> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
>
> Thanks for this submission. This is quite fiddly to review. Can you
> explain what the concrete benefit of this is ?
>
Hi, Ian Jackson.
no concrete benefit, but help for reviewing:
simplify by "allocating" strings from stack.
reduce memory-allocation and reduce error-handling-branch.
path_cmd and path_ret strings are separated.
Thanks,
Lai
next prev parent reply other threads:[~2014-03-14 9:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 14:15 [PATCH 1/5] libxl, gc: fix memory leak in libxl__strndup() Lai Jiangshan
2014-03-11 14:15 ` [PATCH 2/5] libxl: simplify libxl__dirname() Lai Jiangshan
2014-03-13 16:51 ` Ian Jackson
2014-03-11 14:15 ` [PATCH 3/5] libxl: add @count to libxl_gc Lai Jiangshan
2014-03-13 16:52 ` Ian Jackson
2014-03-11 14:15 ` [PATCH 4/5] xc_save: avoid to alloc local constant string Lai Jiangshan
2014-03-13 16:55 ` Ian Jackson
2014-03-11 14:15 ` [PATCH 5/5] xc_save: simplify switch_qemu_logdirty() by use stack strings Lai Jiangshan
2014-03-13 16:54 ` Ian Jackson
2014-03-14 9:21 ` Lai Jiangshan [this message]
2014-03-13 16:50 ` [PATCH 1/5] libxl, gc: fix memory leak in libxl__strndup() Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5322CA0A.3000703@cn.fujitsu.com \
--to=laijs@cn.fujitsu.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=keir.fraser@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.