From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lai Jiangshan <laijs@cn.fujitsu.com>
Subject: Re: [PATCH 5/5] xc_save: simplify
 switch_qemu_logdirty() by use stack strings
Date: Fri, 14 Mar 2014 17:21:14 +0800
Message-ID: <5322CA0A.3000703@cn.fujitsu.com>
References: <1394547325-18537-1-git-send-email-laijs@cn.fujitsu.com>	<1394547325-18537-5-git-send-email-laijs@cn.fujitsu.com>
	<21281.58066.375826.21774@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <21281.58066.375826.21774@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Keir Fraser <keir.fraser@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 03/14/2014 12:54 AM, Ian Jackson wrote:
> Lai Jiangshan writes ("[PATCH 5/5] xc_save: simplify switch_qemu_logdirty() by use stack strings"):
>> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
> 
> Thanks for this submission.  This is quite fiddly to review.  Can you
> explain what the concrete benefit of this is ?
> 
Hi, Ian Jackson.

no concrete benefit, but help for reviewing:

simplify by "allocating" strings from stack.
reduce memory-allocation and reduce error-handling-branch.

path_cmd and path_ret strings are separated.

Thanks,
Lai