From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Hogan Subject: Re: [Qemu-devel] [PATCH v3 6/9] target-mips: kvm: Add main KVM support for MIPS Date: Fri, 14 Mar 2014 09:42:11 +0000 Message-ID: <5322CEF3.9010008@imgtec.com> References: <1394125778-18746-1-git-send-email-james.hogan@imgtec.com> <1394125778-18746-7-git-send-email-james.hogan@imgtec.com> <53222304.3050902@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: , Peter Maydell , , Gleb Natapov , Sanjay Lal , Paolo Bonzini , Aurelien Jarno To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Return-path: Received: from mailapp01.imgtec.com ([195.89.28.115]:37968 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755593AbaCNJmP (ORCPT ); Fri, 14 Mar 2014 05:42:15 -0400 In-Reply-To: <53222304.3050902@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: Hi Andreas, On 13/03/14 21:28, Andreas F=C3=A4rber wrote: >> diff --git a/target-mips/kvm.c b/target-mips/kvm.c >> new file mode 100644 >> index 0000000..0ec343d >> --- /dev/null >> +++ b/target-mips/kvm.c > [...] >> +static inline int kvm_mips_put_one_reg(CPUState *cs, int reg_id, in= t32 *addr) >=20 > Did you mean int32_t? >> +static inline int kvm_mips_get_one_reg(CPUState *cs, int reg_id, in= t32 *addr) >=20 > int32_t? >> + *addr =3D (int32)val64; >=20 > int32_t? > int32 is a type used in softfloat that has weird at-least-as-wide > semantics and bit us in the past. Well spotted, they should indeed be int32_t. > Otherwise looking good now, thanks for the CPU cleanups! We just had > another round of CPU refactorings go in today, but I don't spot a > conflict in this patch. Please rebase your local branch to verify. It rebased clearly, but I'll double check and send a v4 today anyway. Thanks James From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37442) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WOOdD-0001C4-Db for qemu-devel@nongnu.org; Fri, 14 Mar 2014 05:42:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WOOd7-0003WY-Dz for qemu-devel@nongnu.org; Fri, 14 Mar 2014 05:42:23 -0400 Received: from mailapp01.imgtec.com ([195.89.28.115]:47382) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WOOd7-0003WB-4d for qemu-devel@nongnu.org; Fri, 14 Mar 2014 05:42:17 -0400 Message-ID: <5322CEF3.9010008@imgtec.com> Date: Fri, 14 Mar 2014 09:42:11 +0000 From: James Hogan MIME-Version: 1.0 References: <1394125778-18746-1-git-send-email-james.hogan@imgtec.com> <1394125778-18746-7-git-send-email-james.hogan@imgtec.com> <53222304.3050902@suse.de> In-Reply-To: <53222304.3050902@suse.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 6/9] target-mips: kvm: Add main KVM support for MIPS List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: Peter Maydell , kvm@vger.kernel.org, Gleb Natapov , qemu-devel@nongnu.org, Sanjay Lal , Paolo Bonzini , Aurelien Jarno Hi Andreas, On 13/03/14 21:28, Andreas F=C3=A4rber wrote: >> diff --git a/target-mips/kvm.c b/target-mips/kvm.c >> new file mode 100644 >> index 0000000..0ec343d >> --- /dev/null >> +++ b/target-mips/kvm.c > [...] >> +static inline int kvm_mips_put_one_reg(CPUState *cs, int reg_id, int3= 2 *addr) >=20 > Did you mean int32_t? >> +static inline int kvm_mips_get_one_reg(CPUState *cs, int reg_id, int3= 2 *addr) >=20 > int32_t? >> + *addr =3D (int32)val64; >=20 > int32_t? > int32 is a type used in softfloat that has weird at-least-as-wide > semantics and bit us in the past. Well spotted, they should indeed be int32_t. > Otherwise looking good now, thanks for the CPU cleanups! We just had > another round of CPU refactorings go in today, but I don't spot a > conflict in this patch. Please rebase your local branch to verify. It rebased clearly, but I'll double check and send a v4 today anyway. Thanks James