From: srinivas.kandagatla@st.com (srinivas kandagatla)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 4/6] pinctrl: st: Use ARRAY_SIZE instead of raw value for number of delays
Date: Fri, 14 Mar 2014 09:46:49 +0000 [thread overview]
Message-ID: <5322D009.3090000@st.com> (raw)
In-Reply-To: <5322CF87.5000301@st.com>
On 14/03/14 09:44, Maxime Coquelin wrote:
>>>
>>> drivers/pinctrl/pinctrl-st.c- unsigned int *input_delays;
>>> drivers/pinctrl/pinctrl-st.c- unsigned int *output_delays;
>>>
>>> It may be better to change these to const unsigned int *
>>> and change
>>>
>>> static unsigned int stih416_delays[] = {
>>>
>>> to static const
>>
>> Good point. Patches accepted :-)
>
> Sorry Joe, I forgot to reply.
>
> I added this to my todo list.
> I will provide the change before end of next week.
>
Thanks Maxime for taking care of this...
--srini
> Thanks,
> Maxime
WARNING: multiple messages have this Message-ID (diff)
From: srinivas kandagatla <srinivas.kandagatla@st.com>
To: Maxime Coquelin <maxime.coquelin@st.com>,
Linus Walleij <linus.walleij@linaro.org>,
Joe Perches <joe@perches.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Russell King <linux@arm.linux.org.uk>,
kernel@stlinux.com, Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Stuart Menefy <stuart.menefy@st.com>,
Rob Herring <robh+dt@kernel.org>, Rob Landley <rob@landley.net>,
Kumar Gala <galak@codeaurora.org>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Lee Jones <lee.jones@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 4/6] pinctrl: st: Use ARRAY_SIZE instead of raw value for number of delays
Date: Fri, 14 Mar 2014 09:46:49 +0000 [thread overview]
Message-ID: <5322D009.3090000@st.com> (raw)
In-Reply-To: <5322CF87.5000301@st.com>
On 14/03/14 09:44, Maxime Coquelin wrote:
>>>
>>> drivers/pinctrl/pinctrl-st.c- unsigned int *input_delays;
>>> drivers/pinctrl/pinctrl-st.c- unsigned int *output_delays;
>>>
>>> It may be better to change these to const unsigned int *
>>> and change
>>>
>>> static unsigned int stih416_delays[] = {
>>>
>>> to static const
>>
>> Good point. Patches accepted :-)
>
> Sorry Joe, I forgot to reply.
>
> I added this to my todo list.
> I will provide the change before end of next week.
>
Thanks Maxime for taking care of this...
--srini
> Thanks,
> Maxime
WARNING: multiple messages have this Message-ID (diff)
From: srinivas kandagatla <srinivas.kandagatla@st.com>
To: Maxime Coquelin <maxime.coquelin@st.com>,
Linus Walleij <linus.walleij@linaro.org>,
Joe Perches <joe@perches.com>
Cc: Rob Landley <rob@landley.net>, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
Stuart Menefy <stuart.menefy@st.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>, <kernel@stlinux.com>,
Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH v4 4/6] pinctrl: st: Use ARRAY_SIZE instead of raw value for number of delays
Date: Fri, 14 Mar 2014 09:46:49 +0000 [thread overview]
Message-ID: <5322D009.3090000@st.com> (raw)
In-Reply-To: <5322CF87.5000301@st.com>
On 14/03/14 09:44, Maxime Coquelin wrote:
>>>
>>> drivers/pinctrl/pinctrl-st.c- unsigned int *input_delays;
>>> drivers/pinctrl/pinctrl-st.c- unsigned int *output_delays;
>>>
>>> It may be better to change these to const unsigned int *
>>> and change
>>>
>>> static unsigned int stih416_delays[] = {
>>>
>>> to static const
>>
>> Good point. Patches accepted :-)
>
> Sorry Joe, I forgot to reply.
>
> I added this to my todo list.
> I will provide the change before end of next week.
>
Thanks Maxime for taking care of this...
--srini
> Thanks,
> Maxime
next prev parent reply other threads:[~2014-03-14 9:46 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 8:50 [PATCH v4 0/6] Add STiH407 SoC and reference board support Maxime COQUELIN
2014-03-12 8:50 ` Maxime COQUELIN
2014-03-12 8:50 ` [PATCH v4 1/6] ARM: STi: Add STiH407 SoC support Maxime COQUELIN
2014-03-12 8:50 ` Maxime COQUELIN
2014-03-12 9:37 ` Lee Jones
2014-03-12 9:37 ` Lee Jones
2014-03-12 8:50 ` [PATCH v4 2/6] pinctrl: st: Enhance the controller to manage unavailable registers Maxime COQUELIN
2014-03-12 8:50 ` Maxime COQUELIN
2014-03-12 9:38 ` Lee Jones
2014-03-12 9:38 ` Lee Jones
2014-03-12 14:16 ` Linus Walleij
2014-03-12 14:16 ` Linus Walleij
2014-03-12 14:16 ` Linus Walleij
2014-03-12 8:50 ` [PATCH v4 3/6] pinctrl: st: add pinctrl support for the STiH407 SoC Maxime COQUELIN
2014-03-12 8:50 ` Maxime COQUELIN
2014-03-12 14:17 ` Linus Walleij
2014-03-12 14:17 ` Linus Walleij
2014-03-12 14:17 ` Linus Walleij
2014-03-12 8:50 ` [PATCH v4 4/6] pinctrl: st: Use ARRAY_SIZE instead of raw value for number of delays Maxime COQUELIN
2014-03-12 8:50 ` Maxime COQUELIN
2014-03-12 9:39 ` Lee Jones
2014-03-12 9:39 ` Lee Jones
2014-03-12 14:19 ` Linus Walleij
2014-03-12 14:19 ` Linus Walleij
2014-03-12 14:25 ` Joe Perches
2014-03-12 14:25 ` Joe Perches
2014-03-14 9:20 ` Linus Walleij
2014-03-14 9:20 ` Linus Walleij
2014-03-14 9:44 ` Maxime Coquelin
2014-03-14 9:44 ` Maxime Coquelin
2014-03-14 9:44 ` Maxime Coquelin
2014-03-14 9:46 ` srinivas kandagatla [this message]
2014-03-14 9:46 ` srinivas kandagatla
2014-03-14 9:46 ` srinivas kandagatla
2014-03-12 8:50 ` [PATCH v4 5/6] ARM: dts: Add STiH407 SoC support Maxime COQUELIN
2014-03-12 8:50 ` Maxime COQUELIN
2014-05-13 12:04 ` [STLinux Kernel] " Patrice Chotard
2014-05-13 12:04 ` Patrice Chotard
2014-05-13 12:04 ` Patrice Chotard
2014-03-12 8:50 ` [PATCH v4 6/6] ARM: dts: STiH407: Add B2120 board support Maxime COQUELIN
2014-03-12 8:50 ` Maxime COQUELIN
2014-05-13 12:05 ` [STLinux Kernel] " Patrice Chotard
2014-05-13 12:05 ` Patrice Chotard
2014-05-13 12:05 ` Patrice Chotard
2014-05-20 6:18 ` Olof Johansson
2014-05-20 6:18 ` Olof Johansson
2014-05-20 6:18 ` Olof Johansson
2014-05-20 7:20 ` Lee Jones
2014-05-20 7:20 ` Lee Jones
2014-05-20 7:20 ` Lee Jones
2014-05-20 7:24 ` Olof Johansson
2014-05-20 7:24 ` Olof Johansson
2014-05-20 7:43 ` Lee Jones
2014-05-20 7:43 ` Lee Jones
2014-05-20 7:43 ` Lee Jones
2014-05-20 7:53 ` Maxime Coquelin
2014-05-20 7:53 ` Maxime Coquelin
2014-05-20 7:53 ` Maxime Coquelin
2014-05-20 22:10 ` Olof Johansson
2014-05-20 22:10 ` Olof Johansson
2014-05-21 10:02 ` Lee Jones
2014-05-21 10:02 ` Lee Jones
2014-05-20 8:27 ` Maxime Coquelin
2014-05-20 8:27 ` Maxime Coquelin
2014-05-20 8:27 ` Maxime Coquelin
2014-03-12 14:20 ` [PATCH v4 0/6] Add STiH407 SoC and reference " Linus Walleij
2014-03-12 14:20 ` Linus Walleij
2014-03-12 15:26 ` Maxime Coquelin
2014-03-12 15:26 ` Maxime Coquelin
2014-03-12 15:26 ` Maxime Coquelin
2014-03-14 10:14 ` Linus Walleij
2014-03-14 10:14 ` Linus Walleij
2014-03-14 10:14 ` Linus Walleij
2014-04-22 12:17 ` Maxime Coquelin
2014-04-22 12:17 ` Maxime Coquelin
2014-04-22 12:17 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5322D009.3090000@st.com \
--to=srinivas.kandagatla@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.