From mboxrd@z Thu Jan 1 00:00:00 1970 From: antoine.tenart@free-electrons.com (=?UTF-8?B?QW50b2luZSBUw6luYXJ0?=) Date: Fri, 14 Mar 2014 10:48:57 +0100 Subject: [PATCH v2 1/3] ARM: dts: berlin2q: add the Marvell Armada 1500 pro In-Reply-To: <5322CC8B.6010905@gmail.com> References: <1394719607-25018-1-git-send-email-antoine.tenart@free-electrons.com> <1394719607-25018-2-git-send-email-antoine.tenart@free-electrons.com> <5322CC8B.6010905@gmail.com> Message-ID: <5322D089.7010605@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Sebastian, On 14/03/2014 10:31, Sebastian Hesselbarth wrote: > On 03/13/2014 03:06 PM, Antoine T?nart wrote: >> + clocks { >> + #address-cells = <0>; >> + #size-cells = <0>; >> + >> + smclk: sysmgr-clock { >> + compatible = "fixed-clock"; >> + #clock-cells = <0>; >> + clock-frequency = <25000000>; >> + }; >> + >> + sysclk: system-clock { >> + compatible = "fixed-clock"; >> + #clock-cells = <0>; >> + clock-frequency = <400000000>; >> + }; >> + }; >> + >> + soc { > [...] >> + local-timer at ad0600 { >> + compatible = "arm,cortex-a9-twd-timer"; >> + reg = <0xad0600 0x20>; >> + clocks = <&sysclk>; > > If I understand Jisheng correctly, this should be cpuclk/3. When > removing the clocks {} container above, please also take care of > it. > > You can do > > cpuclk: cpu-clock { > compatible = "fixed-clock"; > #clock-cells = <0>; > clock-frequency = <1200000000>; /* <- put correct freq here */ > }; > > sysclk: system-clock { > compatible = "fixed-factor-clock"; > #clock-cells = <0>; > clocks = <&cpuclk>; > clock-multi = <1>; > clock-div = <3>; > }; > > Hopefully, we'll have proper clock drivers soon so we can just replace > referenced "fixed-*" clocks. Sure, this is why I only kept one fixed clock in this patch. I'll add the cpuclk here then. >> + timer0: timer at 2c00 { >> + compatible = "snps,dw-apb-timer"; >> + reg = <0x2c00 0x14>; >> + interrupts = <8>; >> + clock-freq = <100000000>; >> + status = "okay"; >> + }; >> + >> + timer1: timer at 2c14 { >> + compatible = "snps,dw-apb-timer"; >> + reg = <0x2c14 0x14>; >> + clock-freq = <100000000>; >> + status = "disabled"; >> + }; > > Please also add the remaining 6 apb timers. I don't have any information about the remaining 6 apb timers. I'll ask Jisheng. Antoine -- Antoine T?nart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756039AbaCNJtM (ORCPT ); Fri, 14 Mar 2014 05:49:12 -0400 Received: from top.free-electrons.com ([176.31.233.9]:46615 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755869AbaCNJtJ (ORCPT ); Fri, 14 Mar 2014 05:49:09 -0400 Message-ID: <5322D089.7010605@free-electrons.com> Date: Fri, 14 Mar 2014 10:48:57 +0100 From: =?UTF-8?B?QW50b2luZSBUw6luYXJ0?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Sebastian Hesselbarth CC: alexandre.belloni@free-electrons.com, zmxu@marvell.com, jszhang@marvell.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] ARM: dts: berlin2q: add the Marvell Armada 1500 pro References: <1394719607-25018-1-git-send-email-antoine.tenart@free-electrons.com> <1394719607-25018-2-git-send-email-antoine.tenart@free-electrons.com> <5322CC8B.6010905@gmail.com> In-Reply-To: <5322CC8B.6010905@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sebastian, On 14/03/2014 10:31, Sebastian Hesselbarth wrote: > On 03/13/2014 03:06 PM, Antoine Ténart wrote: >> + clocks { >> + #address-cells = <0>; >> + #size-cells = <0>; >> + >> + smclk: sysmgr-clock { >> + compatible = "fixed-clock"; >> + #clock-cells = <0>; >> + clock-frequency = <25000000>; >> + }; >> + >> + sysclk: system-clock { >> + compatible = "fixed-clock"; >> + #clock-cells = <0>; >> + clock-frequency = <400000000>; >> + }; >> + }; >> + >> + soc { > [...] >> + local-timer@ad0600 { >> + compatible = "arm,cortex-a9-twd-timer"; >> + reg = <0xad0600 0x20>; >> + clocks = <&sysclk>; > > If I understand Jisheng correctly, this should be cpuclk/3. When > removing the clocks {} container above, please also take care of > it. > > You can do > > cpuclk: cpu-clock { > compatible = "fixed-clock"; > #clock-cells = <0>; > clock-frequency = <1200000000>; /* <- put correct freq here */ > }; > > sysclk: system-clock { > compatible = "fixed-factor-clock"; > #clock-cells = <0>; > clocks = <&cpuclk>; > clock-multi = <1>; > clock-div = <3>; > }; > > Hopefully, we'll have proper clock drivers soon so we can just replace > referenced "fixed-*" clocks. Sure, this is why I only kept one fixed clock in this patch. I'll add the cpuclk here then. >> + timer0: timer@2c00 { >> + compatible = "snps,dw-apb-timer"; >> + reg = <0x2c00 0x14>; >> + interrupts = <8>; >> + clock-freq = <100000000>; >> + status = "okay"; >> + }; >> + >> + timer1: timer@2c14 { >> + compatible = "snps,dw-apb-timer"; >> + reg = <0x2c14 0x14>; >> + clock-freq = <100000000>; >> + status = "disabled"; >> + }; > > Please also add the remaining 6 apb timers. I don't have any information about the remaining 6 apb timers. I'll ask Jisheng. Antoine -- Antoine Ténart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com