From: Paolo Bonzini <pbonzini@redhat.com>
To: "Radim Krčmář" <rkrcmar@redhat.com>, "Gleb Natapov" <gleb@kernel.org>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] KVM: SVM: fix cr8 intercept window
Date: Fri, 14 Mar 2014 10:57:32 +0100 [thread overview]
Message-ID: <5322D28C.9080009@redhat.com> (raw)
In-Reply-To: <20140313170846.GA23297@potion.brq.redhat.com>
Il 13/03/2014 18:08, Radim Krčmář ha scritto:
> > I agree that old code is wrong and the patch looks correct, but I only
> > see how the bug may cause pending IRR to not be delivered in time,
> > not how interrupt can disrupt a higher priority task.
Right. Also, on SMP guests the effect would likely be just a deadlock
if a lower-priority ISR interrupted a higher priority task and accessed
shared data (since you need anyway a spinlock in addition to raising the
IRQL).
A more likely explanation is that if the remote processor delays an IPI
too much, it will have a stable TLB entry. The resulting random
corruption of paged memory is compatible with the BAD_POOL_HEADER error
codes that Radim observed.
> Paolo, can you change the last sentence to ", which means we don't
> inject pending IRR immediately."? (or do we just forget it?)
It's already in Linus's tree.
Paolo
prev parent reply other threads:[~2014-03-14 9:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 18:11 [PATCH] KVM: SVM: fix cr8 intercept window Radim Krčmář
2014-03-12 1:05 ` Marcelo Tosatti
2014-03-12 10:40 ` Radim Krčmář
2014-03-12 14:54 ` Marcelo Tosatti
2014-03-12 17:20 ` Paolo Bonzini
2014-03-13 13:52 ` Gleb Natapov
2014-03-13 17:08 ` Radim Krčmář
2014-03-14 9:57 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5322D28C.9080009@redhat.com \
--to=pbonzini@redhat.com \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.