From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Holler Subject: Re: [PATCH v2] gpio: davinci: fix gpio selection for OF Date: Fri, 14 Mar 2014 11:08:41 +0100 Message-ID: <5322D529.4070904@ahsoftware.de> References: <5316FFCE.1060603@ti.com> <1394018461-757-1-git-send-email-holler@ahsoftware.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Linus Walleij Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Alexandre Courbot , Grant Likely , Rob Herring , Grygorii Strashko , Sekhar Nori , Prabhakar Lad List-Id: linux-gpio@vger.kernel.org Am 11.03.2014 11:15, schrieb Linus Walleij: > On Wed, Mar 5, 2014 at 12:21 PM, Alexander Holler wrote: > >> The driver missed an of_xlate function to translate gpio numbers >> as found in the DT to the correct chip and number. >> >> While there I've set #gpio_cells to a fixed value of 2. >> >> I've used gpio-pxa.c as template for those changes and tested my changes >> successfully on a da850 board using entries for gpio-leds in a DT. So I didn't >> reinvent the wheel but just copied and tested stuff. >> >> Thanks to Grygorii Strashko for the hint to the existing code in gpio-pxa. >> >> Signed-off-by: Alexander Holler >> Signed-off-by: Grygorii Strashko > > This v2 version applied, thanks! Thanks, but actually that should have been a fix for 3.14 with which the OF functionality for davinci gpio gets introduced. I assum with the patch in for-next, 3.14 will appear with that functionality broken and it will become a candidate for -stable. Regards, Alexander Holler -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: holler@ahsoftware.de (Alexander Holler) Date: Fri, 14 Mar 2014 11:08:41 +0100 Subject: [PATCH v2] gpio: davinci: fix gpio selection for OF In-Reply-To: References: <5316FFCE.1060603@ti.com> <1394018461-757-1-git-send-email-holler@ahsoftware.de> Message-ID: <5322D529.4070904@ahsoftware.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Am 11.03.2014 11:15, schrieb Linus Walleij: > On Wed, Mar 5, 2014 at 12:21 PM, Alexander Holler wrote: > >> The driver missed an of_xlate function to translate gpio numbers >> as found in the DT to the correct chip and number. >> >> While there I've set #gpio_cells to a fixed value of 2. >> >> I've used gpio-pxa.c as template for those changes and tested my changes >> successfully on a da850 board using entries for gpio-leds in a DT. So I didn't >> reinvent the wheel but just copied and tested stuff. >> >> Thanks to Grygorii Strashko for the hint to the existing code in gpio-pxa. >> >> Signed-off-by: Alexander Holler >> Signed-off-by: Grygorii Strashko > > This v2 version applied, thanks! Thanks, but actually that should have been a fix for 3.14 with which the OF functionality for davinci gpio gets introduced. I assum with the patch in for-next, 3.14 will appear with that functionality broken and it will become a candidate for -stable. Regards, Alexander Holler From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753058AbaCNKJe (ORCPT ); Fri, 14 Mar 2014 06:09:34 -0400 Received: from h1446028.stratoserver.net ([85.214.92.142]:55595 "EHLO mail.ahsoftware.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752180AbaCNKJc (ORCPT ); Fri, 14 Mar 2014 06:09:32 -0400 Message-ID: <5322D529.4070904@ahsoftware.de> Date: Fri, 14 Mar 2014 11:08:41 +0100 From: Alexander Holler User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Linus Walleij CC: "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "davinci-linux-open-source@linux.davincidsp.com" , "linux-arm-kernel@lists.infradead.org" , Alexandre Courbot , Grant Likely , Rob Herring , Grygorii Strashko , Sekhar Nori , Prabhakar Lad Subject: Re: [PATCH v2] gpio: davinci: fix gpio selection for OF References: <5316FFCE.1060603@ti.com> <1394018461-757-1-git-send-email-holler@ahsoftware.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 11.03.2014 11:15, schrieb Linus Walleij: > On Wed, Mar 5, 2014 at 12:21 PM, Alexander Holler wrote: > >> The driver missed an of_xlate function to translate gpio numbers >> as found in the DT to the correct chip and number. >> >> While there I've set #gpio_cells to a fixed value of 2. >> >> I've used gpio-pxa.c as template for those changes and tested my changes >> successfully on a da850 board using entries for gpio-leds in a DT. So I didn't >> reinvent the wheel but just copied and tested stuff. >> >> Thanks to Grygorii Strashko for the hint to the existing code in gpio-pxa. >> >> Signed-off-by: Alexander Holler >> Signed-off-by: Grygorii Strashko > > This v2 version applied, thanks! Thanks, but actually that should have been a fix for 3.14 with which the OF functionality for davinci gpio gets introduced. I assum with the patch in for-next, 3.14 will appear with that functionality broken and it will become a candidate for -stable. Regards, Alexander Holler