All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Chris Ball <chris@printf.net>,
	linux-mmc <linux-mmc@vger.kernel.org>,
	Alexandre Courbot <gnurou@gmail.com>,
	Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
	Ulf Hansson <ulf.hansson@stericsson.com>
Subject: Re: [PATCH 1/6] mmc: slot-gpio: Record GPIO descriptors instead of GPIO numbers
Date: Fri, 14 Mar 2014 12:23:54 +0200	[thread overview]
Message-ID: <5322D8BA.8060305@intel.com> (raw)
In-Reply-To: <CACRpkdaHRsASr1jxPcUb+8G25BpOO0kB9mXFi_gocJ9cWmYDDw@mail.gmail.com>

On 14.03.2014 11:06, Linus Walleij wrote:
> On Mon, Mar 10, 2014 at 2:02 PM, Adrian Hunter <adrian.hunter@intel.com> wrote:
> 
>> In preparation for adding a descriptor-based CD GPIO
>> API, switch from recording GPIO numbers to recording
>> GPIO descriptors.
>>
>> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> 
> Certainly this makes things look better from a GPIO POV
> so Acked-by.
> 
> However:
> 
> (...)
>> +       ctx->ro_gpio = gpio_to_desc(gpio);
> (...)
>> +       ctx->cd_gpio = gpio_to_desc(gpio);
> 
> How much harder would it be to switch the platforms using this
> MMC driver to pass GPIO descriptors using the gpiod_lookup_table
> in affected platforms (or device tree or ACPI) and then use
> devm_gpiod_get[_index]() in probe()?

There are 10 drivers plus users of mmc_of_config(), so too much work for me
right now.  Also parts that relate to device-tree are outside my sphere.

> This can certainly be step 2, but that is where we want to go with
> the GPIO clean-up work in the long run.

Perhaps Ulf or Guennadi would be interested.


  reply	other threads:[~2014-03-14 10:24 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-10 13:02 [PATCH 0/6] mmc: sdhci-acpi: Fix broken card detect for ACPI HID 80860F14 Adrian Hunter
2014-03-10 13:02 ` [PATCH 1/6] mmc: slot-gpio: Record GPIO descriptors instead of GPIO numbers Adrian Hunter
2014-03-13 13:00   ` Jaehoon Chung
2014-03-13 13:33     ` Adrian Hunter
2014-03-13 13:39       ` Jaehoon Chung
2014-03-14  1:25         ` Jaehoon Chung
2014-03-14  9:06   ` Linus Walleij
2014-03-14 10:23     ` Adrian Hunter [this message]
2014-03-14 10:28     ` Adrian Hunter
2014-03-10 13:02 ` [PATCH 2/6] mmc: slot-gpio: Split out CD IRQ request into a separate function Adrian Hunter
2014-03-10 13:02 ` [PATCH 3/6] mmc: slot-gpio: Add GPIO descriptor based CD GPIO API Adrian Hunter
2014-03-14  9:07   ` Linus Walleij
2014-03-10 13:02 ` [PATCH 4/6] mmc: sdhci-acpi: Fix broken card detect for ACPI HID 80860F14 Adrian Hunter
2014-03-10 13:02 ` [PATCH 5/6] mmc: sdhci-acpi: Add device id 80860F16 Adrian Hunter
2014-03-10 13:02 ` [PATCH 6/6] mmc: sdhci: Allow for irq being shared Adrian Hunter
2014-03-11  8:09   ` [PATCH V2 " Adrian Hunter
2014-03-17  9:14 ` [PATCH 0/6] mmc: sdhci-acpi: Fix broken card detect for ACPI HID 80860F14 Adrian Hunter
2014-03-17 13:14   ` Chris Ball

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5322D8BA.8060305@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=chris@printf.net \
    --cc=g.liakhovetski@gmx.de \
    --cc=gnurou@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=ulf.hansson@stericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.