From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3][ 3/9] usb: chipidea: Use standard usb-phy property.
Date: Fri, 14 Mar 2014 15:21:59 +0400 [thread overview]
Message-ID: <5322E657.8030905@cogentembedded.com> (raw)
In-Reply-To: <171967ece1414f9ba0e80664777892cb@BL2PR03MB226.namprd03.prod.outlook.com>
Hello.
On 14-03-2014 5:57, Peter Chen wrote:
>>> According to Power_ePAPR_APPROVED_v1.1.pdf "ethernet-phy" is the node
>>> name, it is the same with Sergei's suggestion.
>> Nobody's talking about "ehternet-phy" here.
> Hmm, you take "ethernet-phy" as an example, and suggest changing to "usb-phy" at last email.
Then it's a wrong mail. I'm not mixing nodes and properties.
>>> But you have changed the property name at this patch, in fact,
>> "fsl,usbphy"
>>> is ok for property name, "fsl,usb-phy" may be better, but not worth a
>>> patch to change it.
>> No, it's not better and both are not OK because they're still
>> Freescale specific while the de-facto standard property "usb-phy" is
>> already used by other USB drivers for the same purpose.
> Am I missing something, property name should be the same for all platforms?
If they're doing the same standard thing, yes.
> Peter
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
To: Peter Chen <Peter.Chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
Denis Carikli <denis-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Cc: "Eric Bénard" <eric-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org>,
"Shawn Guo" <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"Sascha Hauer" <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Fabio Estevam"
<festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"Alexander Shiyan" <shc_work-JGs/UdohzUI@public.gmane.org>
Subject: Re: [PATCH v3][ 3/9] usb: chipidea: Use standard usb-phy property.
Date: Fri, 14 Mar 2014 15:21:59 +0400 [thread overview]
Message-ID: <5322E657.8030905@cogentembedded.com> (raw)
In-Reply-To: <171967ece1414f9ba0e80664777892cb-AZ66ij2kwaYFgBIGFwYtMOO6mTEJWrR4XA4E9RH9d+qIuWR1G4zioA@public.gmane.org>
Hello.
On 14-03-2014 5:57, Peter Chen wrote:
>>> According to Power_ePAPR_APPROVED_v1.1.pdf "ethernet-phy" is the node
>>> name, it is the same with Sergei's suggestion.
>> Nobody's talking about "ehternet-phy" here.
> Hmm, you take "ethernet-phy" as an example, and suggest changing to "usb-phy" at last email.
Then it's a wrong mail. I'm not mixing nodes and properties.
>>> But you have changed the property name at this patch, in fact,
>> "fsl,usbphy"
>>> is ok for property name, "fsl,usb-phy" may be better, but not worth a
>>> patch to change it.
>> No, it's not better and both are not OK because they're still
>> Freescale specific while the de-facto standard property "usb-phy" is
>> already used by other USB drivers for the same purpose.
> Am I missing something, property name should be the same for all platforms?
If they're doing the same standard thing, yes.
> Peter
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-03-14 11:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 10:01 [PATCH v3][ 1/9] ARM: dts: mx25: USB block requires only one clock Denis Carikli
2014-03-12 10:01 ` [PATCH v3][ 2/9] ARM: dts: mx35: " Denis Carikli
2014-03-12 10:01 ` [PATCH v3][ 3/9] usb: chipidea: Use standard usb-phy property Denis Carikli
2014-03-12 10:19 ` Lothar Waßmann
2014-03-12 10:36 ` Alexander Shiyan
2014-03-13 3:17 ` Peter Chen
2014-03-13 15:31 ` Sergei Shtylyov
2014-03-14 1:57 ` Peter Chen
2014-03-14 1:57 ` Peter Chen
2014-03-14 11:21 ` Sergei Shtylyov [this message]
2014-03-14 11:21 ` Sergei Shtylyov
2014-03-12 10:01 ` [PATCH v3][ 4/9] usb: chipidea: usbmisc: Add USB Host support for i.MX25/i.MX35 CPUs Denis Carikli
2014-03-13 3:18 ` Peter Chen
2014-03-12 10:01 ` [PATCH v3][ 5/9] ARM: dts: imx25.dtsi: Fix USB support Denis Carikli
2014-03-12 11:08 ` Fabio Estevam
2014-03-13 9:18 ` Denis Carikli
2014-03-12 10:01 ` [PATCH v3][ 6/9] ARM: dts: mbimxsd25 baseboard: Add " Denis Carikli
2014-03-12 10:01 ` [PATCH v3][ 7/9] ARM: dts: i.MX35: " Denis Carikli
2014-03-12 10:01 ` [PATCH v3][ 8/9] ARM: dts: mbimxsd35 baseboard: " Denis Carikli
2014-03-12 10:01 ` [PATCH v3][ 9/9] ARM: imx_v4_v5_defconfig: Enable drivers for i.MX25/i.MX35 " Denis Carikli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5322E657.8030905@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.