From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] stubdom/libxc: Fix build of unsafe
	decompressors
Date: Fri, 14 Mar 2014 11:31:58 +0000
Message-ID: <5322E8AE.808@citrix.com>
References: <1394795769-2037-1-git-send-email-andrew.cooper3@citrix.com>
	<1394796221.6442.32.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1394796221.6442.32.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Sander Eikelenboom <linux@eikelenboom.it>, Keir Fraser <keir@xen.org>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Jan Beulich <JBeulich@suse.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 14/03/14 11:23, Ian Campbell wrote:
> On Fri, 2014-03-14 at 11:16 +0000, Andrew Cooper wrote:
>> c/s b683d68c386 changed the packing attribute on struct lzma_header.
> Since this is third party code (which presumably we want to keep mostly
> in sync) was this a good idea?

It seemed so at the time

> Perhaps we should just revert that portion?

That might be be the easiest option.

Frankly, my opinion is that anything under xen/ is fair game for having
hypervisor style and consistency applied to it.  It should be reasonable
to expect that any code under xen/ is exclusive to the hypervisor, and
the real issue is having library code not obviously separated.

v2 patch on its way.

~Andrew